Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product mul test may be inaccurate? #293

Open
workingjubilee opened this issue Sep 24, 2020 · 0 comments
Open

Product mul test may be inaccurate? #293

workingjubilee opened this issue Sep 24, 2020 · 0 comments
Labels
Bug Something isn't working P-low

Comments

@workingjubilee
Copy link
Member

The product_roundoff() test in src/api/reductions/float_arithmetic.rs reports pretty lousy accuracy: there's a 0~3ulp discrepancy between the two multiplication methods on the f32x8 vector test, at least on some platforms. I unblocked the test for now by widening the amount of acceptable difference from 1ulp, but whatever is going on here should be fixed. It may just be an issue with the way the test is written. It is definitely not a new problem, however, as I only discovered it after clearing out all the other backlogged breakage in the repo, and it only appears to arise on the f32x8 vector test, so this isn't a high priority, as hopefully anyone who actually asks for 8 singles multiplied together knows what they are going to get.

@workingjubilee workingjubilee added Bug Something isn't working P-low labels Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P-low
Projects
None yet
Development

No branches or pull requests

1 participant