Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse validation is oblivious to macro calls #18680

Open
Veykril opened this issue Dec 13, 2024 · 0 comments
Open

Parse validation is oblivious to macro calls #18680

Veykril opened this issue Dec 13, 2024 · 0 comments
Labels
A-diagnostics diagnostics / error reporting A-macro macro expansion A-parser parser issues C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Dec 13, 2024

Rust has two kings of parse errors:

  • Pre-expansion parse errors, error that occur while parsing when something unexpected crops up
  • Post-expansion parse errors (validation errors), parses that are rejected post macro expansion

The latter allows for stuff like unsafe mod foo {} to be accepted by attributes without issues, as long as they don't emit unsafe mod again. That is, unsafe mod is rejected in post expansion by validation. rustc does this by walking the fully expanded file tree with a validation pass. Our validation pass right now walks the unexpanded trees though which means we would (if we had a validation diagnostic for unsafe mod) diagnose the following:

#[cfg(False)]
unsafe mod m {}

where as rustc does not. The reason for this is mainl that rust-analyzer does not work on the fully expanded parse tree of a file, we keep the file parse and the macro parses separate so we need to figure something out here.

@Veykril Veykril added A-diagnostics diagnostics / error reporting A-macro macro expansion A-parser parser issues C-bug Category: bug labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics diagnostics / error reporting A-macro macro expansion A-parser parser issues C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

1 participant