Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abort_on_panic() since Rust 1.81? #488

Open
MarijnS95 opened this issue Sep 5, 2024 · 0 comments
Open

Remove abort_on_panic() since Rust 1.81? #488

MarijnS95 opened this issue Sep 5, 2024 · 0 comments

Comments

@MarijnS95
Copy link
Member

MarijnS95 commented Sep 5, 2024

In #412 @spencercw neatly added a wrapper to catch panics instead of unsoundly unwinding them across an extern "C" boundary. Rust 1.81 now plugged that hole and always aborts already:

https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#abort-on-uncaught-panics-in-extern-c-functions

This should allow us to get rid of the manual catch+abort when our MSRV is 1.81. Unsure if that gets propagated in the same detail to stderr / Android logs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant