Add nostr-keyring

[yukibtc]

No description provided.

[xeruf]

would love to learn more about what this is about :) just integrated keyring.rs in my project: https://forge.ftt.gmbh/janek/mostr/commit/b9f1d461fb2e113ae50b9afbfa6c972c69812ccc

[yukibtc]

would love to learn more about what this is about :) just integrated keyring.rs in my project: https://forge.ftt.gmbh/janek/mostr/commit/b9f1d461fb2e113ae50b9afbfa6c972c69812ccc

The idea is to provide an easy way to save the secret key on any platform (including mobile), using the OS keyring when available otherwise a custom .dat file for other platforms (storing the key as ncryptsec).

Later could be implemented the NostrSigner trait on the NostrKeyring and use it directly to sign events or so, without have to get the secret key from keyring, parse it and construct the keys.

It may be something like:

NostrKeyring::create(<keys>);

let list = NostrKeyring::list();

let keyring = NostrKeyring::open(<public-key>);

let client = Client::new(keyring);

It's just an idea :)

[reyamir]

I see you have some works at https://github.com/rust-nostr/nostr/tree/keyring-v2, what more needs to be done? I can help you on it, this feature quite useful for desktop app.

[yukibtc]

I see you have some works at https://github.com/rust-nostr/nostr/tree/keyring-v2, what more needs to be done? I can help you on it, this feature quite useful for desktop app.

That version was more focused on the custom .dat file instead of the OS keyring.

I think could be good to just implement a NostrKeyring with the OS keyring for now. The only platform not supported at the moment by keyring-rs is android and I think is not a problem for now.

---

I thought to another solution, that will involve the persistent database instead of a .dat file, and optionally the OS keyring.

• Store the encrypted secret key (ncryptsec) into a database (could be LMDB, Indexedb or so, the same of the events or another one)
• The secret key can be encrypted with a random key stored later into the OS keyring or with a custom one that could be also stored into the OS keyring or inserted manually every time (this will allow the usage of the NostrKeyring also on android).

What do you think? @reyamir @xeruf

[reyamir]

I think the the persistent database solution a bit complex, since OS keyring is almost ready and fully tested. Or I wonder can we have something like KeyringStorage which user can choose where to store their key?, like we can have OS keyring first, then we can add other storage like custom .dat later.

[xeruf]

I think going with keyring.rs directly is perfectly fine, because it allows providing custom storage backends: https://docs.rs/keyring/latest/keyring/#client-provided-credential-stores

So an Android implementation could be made directly for the library for the benefit of everyone.
It is actually in progress: hwchen/keyring-rs#127