Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The iomap_base of TaskStateSegment shouldn't be initialized to zero #195

Closed
josephlr opened this issue Oct 17, 2020 · 2 comments · Fixed by #357
Closed

The iomap_base of TaskStateSegment shouldn't be initialized to zero #195

josephlr opened this issue Oct 17, 2020 · 2 comments · Fixed by #357

Comments

@josephlr
Copy link
Contributor

josephlr commented Oct 17, 2020 •
edited
Loading

Right now TaskStateSegment::new() initializes iomap_base to 0. This is wrong if we want a "new" TSS to represent one without an IO Map, as this causes the TSS itself to be interpreted as an IO map.

Initializing it to size_of::<TaskStateSegment>(), seems more correct. When creating a segment with tss_segment, this would make it so there is actually not an IO map.

Discovered when reviewing #194
@josephlr josephlr changed the title The iomap_base of TaskStateSegment shouldn The iomap_base of TaskStateSegment shouldn't be initialized to zero Oct 17, 2020
@Restioson
Copy link
Member

Should I just address this in #194?

@josephlr
Copy link
Contributor Author

It will depend on exactly what interface we end up with, but I think a separate PR will be better.

This was referenced Mar 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tss: Initialize iopb to be empty instead of zero rust-osdev/x86_64
2 participants
@josephlr @Restioson