-
Notifications
You must be signed in to change notification settings - Fork 21
Use docker to enable CI builds #25
Comments
Fixed by rust3ds/ctru-rs#35 |
Not quite, unfortunately. This change (adding alloc_system to Cargo.toml) breaks the build according to Travis-CI. rust3ds/ctru-rs@54d7fc6 |
It builds fine here, maybe retry the build (you can do that from within travis). |
Wtf, it works fine locally and it breaks on travis. Devkit probably has nothing to do with it since it also built fine with the corresponding env vars unset. |
Oh, actually it's |
Things seem to be working pretty well now. One suggestion I have though is that the compile-test should separately report success and failure for builds against the pinned nightly vs the latest nightly. If you check out my recent PRs, you'll see that the test reports all green even though there's actually breakage on the latest nightly. Ideally it should say 1 passed, 1 failed |
@FenrirWolf If you'd prefer it that way, then just remove the |
I just figure that way we get a better heads-up about upcoming nightly breakage. Then when we fix it, we can re-pin a newer nightly, then wash, rinse, repeat. Though if the idea is to not do frequent updates to the pinned nightly version, we can probably things the way they are. Just depends on what the goal is I suppose. |
No idea what this entails, but it might be useful to have CI builds on PRs.
The text was updated successfully, but these errors were encountered: