Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Use docker to enable CI builds #25

Open
HybridEidolon opened this issue Feb 26, 2017 · 8 comments
Open

Use docker to enable CI builds #25

HybridEidolon opened this issue Feb 26, 2017 · 8 comments

Comments

@HybridEidolon
Copy link
Member

No idea what this entails, but it might be useful to have CI builds on PRs.

@FenrirWolf
Copy link
Member

Fixed by rust3ds/ctru-rs#35

@HybridEidolon
Copy link
Member Author

Not quite, unfortunately. This change (adding alloc_system to Cargo.toml) breaks the build according to Travis-CI. rust3ds/ctru-rs@54d7fc6

@panicbit
Copy link
Member

It builds fine here, maybe retry the build (you can do that from within travis).

@panicbit
Copy link
Member

panicbit commented Jul 26, 2017

Wtf, it works fine locally and it breaks on travis. Devkit probably has nothing to do with it since it also built fine with the corresponding env vars unset.

@panicbit
Copy link
Member

Oh, actually it's cargo test that is broken!

@FenrirWolf
Copy link
Member

FenrirWolf commented Jul 30, 2017

Things seem to be working pretty well now. One suggestion I have though is that the compile-test should separately report success and failure for builds against the pinned nightly vs the latest nightly. If you check out my recent PRs, you'll see that the test reports all green even though there's actually breakage on the latest nightly. Ideally it should say 1 passed, 1 failed

@panicbit
Copy link
Member

@FenrirWolf If you'd prefer it that way, then just remove the matrix part from the .travis.yml.

@FenrirWolf
Copy link
Member

I just figure that way we get a better heads-up about upcoming nightly breakage. Then when we fix it, we can re-pin a newer nightly, then wash, rinse, repeat.

Though if the idea is to not do frequent updates to the pinned nightly version, we can probably things the way they are. Just depends on what the goal is I suppose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants