Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Fix tensor name API #369

Closed
philpax opened this issue Jul 15, 2023 · 0 comments
Closed

Fix tensor name API #369

philpax opened this issue Jul 15, 2023 · 0 comments
Labels
issue:enhancement New feature or request meta:maintenance Changes that will make it easier for us to maintain code topic:api-design API design considerations, including new functionality and changes
Milestone
0.2

Comments

@philpax
Copy link
Collaborator

philpax commented Jul 15, 2023

There are two major issues with the tensor name API at present:

  • ggml::set_[tensor_]name is exposed, when all code should instead use Tensor::set_name
  • Tensor::[get_]name doesn't use CString to ingest the string from the C side

I'll fix these after #325 lands
@philpax philpax added issue:enhancement New feature or request meta:maintenance Changes that will make it easier for us to maintain code topic:api-design API design considerations, including new functionality and changes labels Jul 15, 2023
@philpax philpax added this to the 0.2 milestone Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue:enhancement New feature or request meta:maintenance Changes that will make it easier for us to maintain code topic:api-design API design considerations, including new functionality and changes
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@philpax