Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only represent references between AST structures with IDs #10

Open
fitzgen opened this issue May 22, 2019 · 0 comments
Open

Only represent references between AST structures with IDs #10

fitzgen opened this issue May 22, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@fitzgen
Copy link
Member

fitzgen commented May 22, 2019

I'm currently making a first pass over this crate's API to make it id-based similar to walrus (it is currently "physical" in that you have to maintain the index references yourself, similar to parity-wasm).

My first pass will represent refs between AST things as essentially enum ThingRef { Id(id), Name(String), Index(u32) } and then there will be a validation/canonicalization pass that ensures everything is an Id.

However, we would like to only have Ids, and to do that we need to add some validation into the middle of parsing with lalrpop's fallible actions (lalrpop/lalrpop#387).

@fitzgen fitzgen added the enhancement New feature or request label May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant