Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentize views/admin folder #353

Closed
asr2003 opened this issue Mar 6, 2024 · 10 comments
Closed

Componentize views/admin folder #353

asr2003 opened this issue Mar 6, 2024 · 10 comments
Assignees
Labels

Comments

@asr2003
Copy link

asr2003 commented Mar 6, 2024

Feature Description 📝

I propose to componentize the views/admin folder in our project. Currently, the views are contained in a single file and to improve code organization and maintainability, I suggest breaking it down into smaller, reusable components of files:

  1. CooperatorsView.vue,
  2. DashboardView.vue
  3. ManagerView.vue
  4. SettingsView.vue
  5. TemplateView.vue

Motivation 🌟

By componentizing the views folder, we can achieve the following benefits:

  1. Modularity: Breaking down views into smaller components improves modularity, making it easier to manage and understand each part of the application.
  2. Reusability: Components can be reused across different parts of the project, reducing redundancy and promoting consistency.
  3. Maintainability: Smaller components are easier to maintain and update, contributing to a more maintainable codebase.

Expected Behavior 🤔

The expected behavior is to have separate Vue.js components for each view in the views folder. Each component should encapsulate the logic and styles related to its specific view.

Additional Information ℹ️

Will make a PRs for every file componentized as discussed above for better review and organized

Thank you for considering this feature request! 🙌

@asr2003 asr2003 added the Enhancement New feature or request label Mar 6, 2024
@asr2003
Copy link
Author

asr2003 commented Mar 6, 2024

@KarinePistili @jvJUCA I would like to work on this issue. Can you please assign me this issue?

By fixing this issue, It also helps me in getting a better understand of entire codebase before making a proposal for GSOC .

@asr2003
Copy link
Author

asr2003 commented Mar 6, 2024

And a thing to discuss I am thinking to move the components to the components folder instead componentize in a single file. It helps in better organizing and reusuability of components.

@KarinePistili @jvJUCA What are your thoughts on this ? Glad to work under your guidance.

@varshith257
Copy link

varshith257 commented Mar 8, 2024

@jvJUCA I think it's a valid approach and makes sense

@Jaishree2310
Copy link

Hello,
I've been closely following the discussions around improving the code organization and maintainability of the project, and I'm excited to propose componentizing the views/admin folder. This refactor aims to break down the current monolithic views into smaller, reusable Vue.js components, such as CooperatorsView.vue, DashboardView.vue, ManagerView.vue, SettingsView.vue, and TemplateView.vue.

This approach not only aligns with our goals for modularity and maintainability but also enhances the reusability of our components across the application. By encapsulating logic and styles within dedicated components, we can significantly improve the project's overall code quality and ease of maintenance.

I plan to undertake this task with careful consideration of the current codebase's structure and needs, ensuring that each component is designed with reusability and maintainability in mind. I will also document the changes thoroughly and create individual pull requests for each component to facilitate a smooth review process.

I'm eager to contribute to this important aspect of the project and would appreciate the opportunity to be assigned to this issue. I'm ready to discuss my proposed approach further and collaborate with the team to make this enhancement a success.

Thank you for considering my proposal.

@jvJUCA jvJUCA assigned jvJUCA and asr2003 and unassigned jvJUCA Mar 11, 2024
@jvJUCA
Copy link
Member

jvJUCA commented Mar 11, 2024

Ok, assigned @asr2003!

@asr2003
Copy link
Author

asr2003 commented Mar 11, 2024

And a thing to discuss I am thinking to move the components to the components folder instead componentize in a single file. It helps in better organizing and reusuability of components.

@KarinePistili @jvJUCA What are your thoughts on this ? Glad to work under your guidance.

@jvJUCA Any thoughts on this?

@jvJUCA
Copy link
Member

jvJUCA commented Mar 11, 2024

And a thing to discuss I am thinking to move the components to the components folder instead componentize in a single file. It helps in better organizing and reusuability of components.
@KarinePistili @jvJUCA What are your thoughts on this ? Glad to work under your guidance.

@jvJUCA Any thoughts on this?

Dear @asr2003,

Thank you for suggesting this adjustment. Currently, our project structure already includes a components folder. Within this folder, we've organized our components into organisms, molecules, and atoms, representing large, medium, and small components, respectively. This hierarchical organization has been serving us well in terms of maintaining clarity and facilitating component reusability.

Best regards,

@jvJUCA

@asr2003
Copy link
Author

asr2003 commented Mar 11, 2024

@jvJUCA I need a suggestion our project lacks the CI/CD pipeline support. Implementing CI/CD brings automation to testing, builds and deployments. This leads to faster and more reliable development cycles, consistent and error-resistant codebase of RUXAILAB.
Any suggestion on this?

@KarinePistili
Copy link
Member

Hello! @asr2003 , have you worked on this? I don't remember seeing the PR, so I'm a little confused if this was already done or is a WIP.

@asr2003
Copy link
Author

asr2003 commented Apr 16, 2024

Yes, It's in WIP. Currently I have exams and will complete in next 3 days. Will start remaining work and submit PR in the weekend :)

@KarinePistili KarinePistili closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants