-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: improve code structure to make it easier to change between models we are using #20
Comments
@KarinePistili I would like to work on this issue. Can you assign it to me? |
What I can understand from your issue is that if we have some kind of switching system inside our codebase, users can easily switch between the models for the regression task. cc: @KarinePistili |
hello @sitamgithub-MSIT , assigned! |
About your question: Yes, exactly. We want an easy way to developers to change between the models. It would be important as well, to document how to make the change so it is easy for the users that would like to switch the models for their tests. We are open to your suggestions on how to implement this, so share with us when you have an idea. |
Upon initial inspection, I have been considering the idea of maintaining a model configuration file. The objective is to allow for the running of our gaze_tracker.py file for a specific model simply by modifying the model configuration file. The configuration file should contain the models and their corresponding hyperparameters, as well as a training flag, which is essentially a boolean field. If set to true, training will be performed for the selected model; otherwise, it will not. |
This is the initial idea that I had. Although I will try to find another way to figure it out. |
I think it could work. @hvini what do you think about this? |
I looked into the backend codebase a little bit. I started by looking at the As of right now, the cc: @KarinePistili @hvini |
One more thing I would like you to clarify for me is that, although the As seen below, there are two more comparable situations in the predict method where we initialize our models:
What I am interested in knowing right now is whether there is a slim possibility that we will use two distinct models for the x and y coordinates. If not, repetitive code can be removed. |
This is possibly how the .yaml file looks. Though subject to change during implementation based on project requirements and workability.
And our model code part can look like this:
Nevertheless, I have not tested it yet. To me, the frontend codebase and configuration remain unexplored. It could take some time to set up and configure Firebase. However, in my opinion, we can test it eventually without actually setting anything up. For the purpose of testing whether it works or not, even an YAML file, the gaze_tracker file, and an artificially generated dataset similar to actual data will do! |
Right now we only have the linear regression model integrated. We would like to have an architecture that facilitate us to changing between this method to other implementations made by the future contributors.
The text was updated successfully, but these errors were encountered: