Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QUERY Method #2873

Open
2 tasks done
hawkinsw opened this issue Oct 3, 2024 · 0 comments · May be fixed by #2874
Open
2 tasks done

Implement QUERY Method #2873

hawkinsw opened this issue Oct 3, 2024 · 0 comments · May be fixed by #2874
Labels
request Request for new functionality

Comments

@hawkinsw
Copy link

hawkinsw commented Oct 3, 2024

What's missing?

I am a huge fan of Rocket and thought that I could add support for the nearly-standardized QUERY method (https://www.ietf.org/archive/id/draft-ietf-httpbis-safe-method-w-body-05.html). I have a WIP PR that I will post to go along with this Feature Request. I have done my absolute best to make sure that I have followed all the proper steps.

Ideal Solution

I believe that the ideal solution is to simply add QUERY in the appropriate spot in the call(s) to the define_methods macro. Because QUERY is not yet an RFC, there will be a few changes to the define_methods macro so that the documentation is generated correctly.

Why can't this be implemented outside of Rocket?

N/A

Are there workarounds usable today?

N/A

Alternative Solutions

No response

Additional Context

Again, thank you for all the work that you are doing on Rocket. I understand that the PR that I will post does not have tests and that is absolutely a requirement. However, I wanted to post early/often to see whether support for QUERY is something that you would consider. If it is, then I will absolutely add all the tests necessary and clean up anything else that I have done incorrectly.

System Checks

  • I do not believe that this feature can or should be implemented outside of Rocket.
  • I was unable to find a previous request for this feature.
@hawkinsw hawkinsw added the request Request for new functionality label Oct 3, 2024
hawkinsw added a commit to hawkinsw/Rocket that referenced this issue Oct 3, 2024
@hawkinsw hawkinsw linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant