-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JetBrainsMono NFM (Light, Thin, etc.) broken since v3.1.1 #1473
Comments
This is basically a duplicate of #1434 which reverts the breaking change made in v3.1.0. Resolution: Use the old name |
nerd-fonts has a breaking change (again) on v3.1.1, which reverts the breaking change on font name (-> "NFM") introduced in v3.1.0. Using the correct font name "JetBrainsMono Nerd Font Mono" fixes the dimming font issue. See ryanoasis/nerd-fonts#1473
Is this really solved? I cant wrap my head around all this right now, maybe because its 1st of January and I'm tired ;-) |
Happy new year! I can't really explain why it broke when it used the "NFM" name only for Light and Thin (probably v3.1.1 does not have these font family...), but after changing the name to what it was used to "... Nerd Font Mono" everything seems fine. |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
JetBrainsMono NFM Light is broken. It has different color when rendered by some terminals, and another terminal claims that the font description "JetBrainsMono NFM" style: "Light" not found.
Looking at the binary file,
{ family = 'JetBrainsMono NFM Light', weight = 'Regular' }
seems to work. Wait, what is "JetBrainsMono NFM Light"?There is a font name "JetBrainsMono NFM Light" which works OK, instead of "JetBrainsMono NFM" with style/weight = Light. Font name change is an unexpected, breaking change.
Since more than two terminals have some issues with "Thin" or "Light" style font (Other weights are fine), I assume that this is a problem of Font, given that the font update was only a minor patch release.
Expected behavior:
It was fine in v3.1.0. The font renders OK in a "light" style.
Example symbols: Every single character.
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
v3.1.1 Light, on Wezterm: see wez/wezterm#4126
Look at dimmed foreground (white) color. Also,
M.setup_fonts()
whereM
is boldfaced. The color are different thansetup_fonts()
, both are #ffaf00.v3.1.1 Regular: works Fine
Alacritty
The text was updated successfully, but these errors were encountered: