Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrainsMono NFM (Light, Thin, etc.) broken since v3.1.1 #1473

Closed
3 tasks done
wookayin opened this issue Jan 1, 2024 · 5 comments
Closed
3 tasks done

JetBrainsMono NFM (Light, Thin, etc.) broken since v3.1.1 #1473

wookayin opened this issue Jan 1, 2024 · 5 comments

Comments

@wookayin
Copy link

wookayin commented Jan 1, 2024

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

JetBrainsMono NFM Light is broken. It has different color when rendered by some terminals, and another terminal claims that the font description "JetBrainsMono NFM" style: "Light" not found.

Looking at the binary file, { family = 'JetBrainsMono NFM Light', weight = 'Regular' } seems to work. Wait, what is "JetBrainsMono NFM Light"?

There is a font name "JetBrainsMono NFM Light" which works OK, instead of "JetBrainsMono NFM" with style/weight = Light. Font name change is an unexpected, breaking change.

Since more than two terminals have some issues with "Thin" or "Light" style font (Other weights are fine), I assume that this is a problem of Font, given that the font update was only a minor patch release.

Expected behavior:

It was fine in v3.1.0. The font renders OK in a "light" style.

Example symbols: Every single character.

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • JetBrainsMonoNerdFontMono-Light.ttf
  • Where did you get the file from (download link, self patched, source downloaded from link...)
    • Homebrew
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • Wezterm nightly, Alacritty 0.13
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • macOS Sonoma

★ Screenshots (Optional)

v3.1.1 Light, on Wezterm: see wez/wezterm#4126

v3.1.1 Light

Look at dimmed foreground (white) color. Also, M.setup_fonts() where M is boldfaced. The color are different than setup_fonts(), both are #ffaf00.

v3.1.1 Regular: works Fine

v3.1.1 Regular

Alacritty

image
@wookayin wookayin changed the title JetBrainsMono NFM (Light) broken since v3.1.1 JetBrainsMono NFM (Light, Thin, etc.) broken since v3.1.1 Jan 1, 2024
@wookayin
Copy link
Author

wookayin commented Jan 1, 2024

Related #1434 #1439

@wookayin
Copy link
Author

wookayin commented Jan 1, 2024

This is basically a duplicate of #1434 which reverts the breaking change made in v3.1.0.

Resolution: Use the old name JetBrainsMono Nerd Font Mono, not JetBrainsMono NFM.

@wookayin wookayin closed this as completed Jan 1, 2024
wookayin added a commit to wookayin/dotfiles that referenced this issue Jan 1, 2024
nerd-fonts has a breaking change (again) on v3.1.1, which reverts the
breaking change on font name (-> "NFM") introduced in v3.1.0.

Using the correct font name "JetBrainsMono Nerd Font Mono" fixes the
dimming font issue.

See ryanoasis/nerd-fonts#1473
@Finii
Copy link
Collaborator

Finii commented Jan 1, 2024

Is this really solved? I cant wrap my head around all this right now, maybe because its 1st of January and I'm tired ;-)
I lost track in my head what has been changed when, sorry.

@wookayin
Copy link
Author

wookayin commented Jan 1, 2024

Happy new year! I can't really explain why it broke when it used the "NFM" name only for Light and Thin (probably v3.1.1 does not have these font family...), but after changing the name to what it was used to "... Nerd Font Mono" everything seems fine.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants