-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpatched CommitMono and patched CommitMono looks different #1696
Comments
I actually think patched version looks better. 🤔 |
Strange, the original font does not have hints ("blue zones" as that is a postscript open type font): The outlines are identical but the hints help to render text at small sizes better. I assume the difference gets smaller and smaller the bigger the size is? Edit: Here blue zones in the patched font but not in the original |
This is a bug with the CommitMono repo
We fix the problem of the original font automagically when patching 😬 I will try to get the original with blues... Edit: Add 'when patching' |
Please try the original fonts from THIS link: https://github.com/eigilnikolajsen/commit-mono/tree/main/src/fonts/fontlab First uninstall the current CommitMono fonts; do not install the font from the link above just "over" existing fonts - the version is the same so Windows will not detect any change and use the cached font file. BlueValues from the files in the link above (400-Regular)
BlueValues we deduce and put into the patched font, same same, reconstruction / repair successful 🎉
(Hmm, normally the BlueValues should be ordered, like we do - no clue if that has any detrimental effect. Can not find any real specs for Postscriptfonts 😬 ) Please do a comparison and report back 😺 |
Unpatched one is still thicker than the patched one. fontlab one looks different to zip one. I still think nerd font version is the best looking one. 😮 |
Hmm, I do not quite understand it. Anyhow, checked what happens if we patch a 'correct' Postscript font, i.e. one with Blue values. Took the "fontlab" font and patched it. The Blue values are preserved, just a BlueShift is added. With 6 that should make no difference at your font size. [1] Maybe you can check that font, and produce a screenshot like the ones before. Sorry to bother you with this, but I have no Windows box here; usually I test via RDP or NX on some other machine, but especially hinting is often completely ignored over network protocol. CommitMonoV143400NerdFont-Regular.otf.zip 2MB
CommitMonoV143-400Regular.otf
CommitMonoV143400NerdFont-Regular.otf and additionally:
CommitMono-400-Regular.otf
CommitMonoNerdFont-Regular.otf [1] https://glyphsapp.com/learn/hinting-postscript-autohinting#g-blueshift Edit: Add link to Glyphs |
Fired up Glyphs3 to examine the fonts further... Note:
Screen.Recording.2024-08-29.at.12.15.02.mov |
I think |
After using |
Glad to hear that :-) I will try to help upstream to get the font file bugs squished out (see eigilnikolajsen/commit-mono#69 further down). The next NF release will use the 'correct' CommitMono files. Thank you so much for helping actively!! 💚 |
@allcontributors please add @doongjohn for bug |
I've put up a pull request to add @doongjohn! 🎉 |
Requirements
Experienced Behavior
CommitMono-400-Regular
vsCommitMonoNerdFont-Regular
looks different.Unpatched font is little bit thicker than patched font.
Expected Behavior
They should be same.
Example Symbols or Text
Any text.
Font Used
CommitMonoNerdFont-Regular.otf
Source of Font File
https://github.com/ryanoasis/nerd-fonts/releases/download/v3.2.1/CommitMono.zip
Terminal Emulator (and the title of the terminal window)
No response
Operating System and Version
Windows 11
Screenshots
The text was updated successfully, but these errors were encountered: