Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPSM config should be sync #19

Closed
DavidLeoni opened this issue Dec 17, 2017 · 0 comments
Closed

SPSM config should be sync #19

DavidLeoni opened this issue Dec 17, 2017 · 0 comments
Assignees
Labels

Comments

@DavidLeoni
Copy link
Member

Currently SPSM config is async, but it doesn't work, as reported by a user in s-match/s-match-core#10 and by by @gbella :

The reason SPSM is not being executed while using the s-match-spsm.xml profile while it is executed when using the s-match-spsm-asymmetric.xml profile is that the former one is using asynchronous mode while the latter one is synchronous. However, the SPSM package does not have the "asyncTreeMatch" method implemented that the asyncMatchManager is trying to call. The result is that the asyncMatchManager falls back to a default tree matcher instead of SPSM. So the solution is to modify the s-match-spsm.xml to use synchronous mode instead (since we are not going to implement asynchronous SPSM). The way to do this is to replace in the XML the line:

<import resource="s-match.xml"/>

by

<import resource="s-match-synchronous.xml"/>
@DavidLeoni DavidLeoni added the bug label Dec 17, 2017
@DavidLeoni DavidLeoni self-assigned this Dec 17, 2017
autayeu added a commit that referenced this issue Dec 18, 2017
Fixes #19 - spsm config should be sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant