Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CI lint for generated code #9

Open
vrongmeal opened this issue Jan 9, 2025 · 0 comments
Open

Better CI lint for generated code #9

vrongmeal opened this issue Jan 9, 2025 · 0 comments

Comments

@vrongmeal
Copy link
Member

With Go GRPC generated code, the first few lines contain information about which exact version of protoc, protoc-gen-go and protoc-gen-go-grpc is used. It's informational but with every minor update, the lint check fails.

There are two possible solutions:

  1. Pin everything to a specific version: This might be extremely annoying while development
  2. Ignore these lines from the diff check: Since we're checking the exact code output, and dependency versions are defined by our go.mod, ignoring these lines in the diff should be OK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant