Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY'ify fork tests through a shared contract #1127

Open
smol-ninja opened this issue Dec 23, 2024 · 0 comments
Open

DRY'ify fork tests through a shared contract #1127

smol-ninja opened this issue Dec 23, 2024 · 0 comments
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Dec 23, 2024 •
edited
Loading

Now that we have a singleton contract, lets look into how the fork tests can be DRY'ified.

They seem to have more than 90% common code. Any small change in one file requires doing it in all the files (see this commit in airdrops repo). If we are able to find a way to DRY'ify fork tests in Lockup, we can do the same with airdrops tests as well.
@smol-ninja smol-ninja added effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smol-ninja