Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperdrive Trading App #378

Open
8 tasks done
cashd opened this issue Jul 12, 2024 · 16 comments
Open
8 tasks done

Add Hyperdrive Trading App #378

cashd opened this issue Jul 12, 2024 · 16 comments

Comments

@cashd
Copy link

cashd commented Jul 12, 2024

Entry type

  • New addition

App info

URL: https://app.hyperdrive.box/

Name: Hyperdrive Trading

Description: Get yield, your way. Access fixed and variable yields at your control with Hyperdrive.

Icon (PNG, 180x180):
hyperdrive-logo-white-black 2

Homepage:
Twitter: https://twitter.com/delv_tech
GitHub: https://github.com/delvtech
Discord: https://discord.com/invite/EEfKmfQdtx

App supports batching multiple transactions via Safe: yes/no

Supported networks

- Mainnet

Revision checks

  • Used smart contracts were audited.
  • You have implemented the app using the Safe Apps SDK
  • Your Safe App includes a manifest.json file at the root with the required data – please paste the link to manifest.json here – apps without a manifset WILL NOT be accepted.
  • The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
  • The app auto-connects to the Safe as a wallet
  • It doesn't try to connect to the browser wallet (e.g. MetaMask)
  • You are able to trigger and execute one transaction with a Safe.
  • RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://docs.hyperdrive.box/security/security-for-the-hyperdrive-protocol

Code for review

https://github.com/delvtech/hyperdrive-frontend/tree/main/apps/hyperdrive-trading

Team information

Company: DELV

Official website: https://delv.tech/

Point of contact: Charles St. Louis

Email/Telegram: [email protected]

@kirkkonen
Copy link

This one was approved by the product team.

@katspaugh
Copy link
Member

@cashd I don't see the icon. Is it white on white?

@cashd
Copy link
Author

cashd commented Aug 8, 2024

@cashd I don't see the icon. Is it white on white?

Yes it is, I went ahead and change it to white on black instead of a transparent background. Good catch thank you!

@francovenica
Copy link

Is said in the description that the app supports Sepolia, but I get a "wrong network" if I try the URL also given in the description.
Is there another URL for sepolia?
image

@katspaugh
Copy link
Member

@cashd are your contracts verified on etherscan?

@CPSTL
Copy link

CPSTL commented Aug 9, 2024

Is said in the description that the app supports Sepolia, but I get a "wrong network" if I try the URL also given in the description. Is there another URL for sepolia? image

Yes - the Testnet is hosted at https://testnet.hyperdrive.box/

@cashd
Copy link
Author

cashd commented Aug 9, 2024

@cashd are your contracts verified on etherscan?

All contracts on mainnet are verified, although not all sepolia contracts are. The app linked only supports production deployments so I will edit the supported chain list.

@katspaugh
Copy link
Member

@francovenica do I get it right that this app has been tested and you approved it?

@francovenica
Copy link

@katspaugh No, I'll move the ticket back

The bridge seems not to be compatible with the safe. You cannot choose the safe as the source of the tokens being bridged:
image

@cashd
Copy link
Author

cashd commented Sep 4, 2024

@katspaugh No, I'll move the ticket back

The bridge seems not to be compatible with the safe. You cannot choose the safe as the source of the tokens being bridged: image

This bridge is facilitated via SquidRouter and we use their components to support cross-chain bridging in app. Would this be a blocker? If so, we can remove this page from being visible if the dapp connector is safe.

@francovenica
Copy link

I have no objections with hiding it

@katspaugh what about you?

@CPSTL
Copy link

CPSTL commented Sep 19, 2024

How are we looking in terms of getting this merged now? Thanks :) @katspaugh @francovenica

@katspaugh
Copy link
Member

katspaugh commented Sep 20, 2024

Let us know when the bridge is hidden, then @francovenica will test it one last time.

@cashd
Copy link
Author

cashd commented Sep 23, 2024

Hey @katspaugh @francovenica! We decided to remove the inline bridge functionality altogether so we should be good now. Let me know if anything else needs to be done.

@francovenica
Copy link

Hi there. sorry for taking so long.
Yeah, without the bridge we are good.

LGTM

@cashd
Copy link
Author

cashd commented Oct 14, 2024

Hey! Just checking in to see if there is any remaining tasks on our end 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to merge
Development

No branches or pull requests

5 participants