-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hyperdrive Trading App #378
Comments
This one was approved by the product team. |
@cashd I don't see the icon. Is it white on white? |
Yes it is, I went ahead and change it to white on black instead of a transparent background. Good catch thank you! |
@cashd are your contracts verified on etherscan? |
Yes - the Testnet is hosted at https://testnet.hyperdrive.box/ |
All contracts on mainnet are verified, although not all sepolia contracts are. The app linked only supports production deployments so I will edit the supported chain list. |
@francovenica do I get it right that this app has been tested and you approved it? |
@katspaugh No, I'll move the ticket back The bridge seems not to be compatible with the safe. You cannot choose the safe as the source of the tokens being bridged: |
This bridge is facilitated via SquidRouter and we use their components to support cross-chain bridging in app. Would this be a blocker? If so, we can remove this page from being visible if the dapp connector is safe. |
I have no objections with hiding it @katspaugh what about you? |
How are we looking in terms of getting this merged now? Thanks :) @katspaugh @francovenica |
Let us know when the bridge is hidden, then @francovenica will test it one last time. |
Hey @katspaugh @francovenica! We decided to remove the inline bridge functionality altogether so we should be good now. Let me know if anything else needs to be done. |
Hi there. sorry for taking so long. LGTM |
Hey! Just checking in to see if there is any remaining tasks on our end 🙏 |
Entry type
App info
URL: https://app.hyperdrive.box/
Name: Hyperdrive Trading
Description: Get yield, your way. Access fixed and variable yields at your control with Hyperdrive.
Icon (PNG, 180x180):
Homepage:
Twitter: https://twitter.com/delv_tech
GitHub: https://github.com/delvtech
Discord: https://discord.com/invite/EEfKmfQdtx
App supports batching multiple transactions via Safe: yes/no
Supported networks
Revision checks
manifest.json
file at the root with the required data – please paste the link to manifest.json here – apps without a manifset WILL NOT be accepted.Audit document
https://docs.hyperdrive.box/security/security-for-the-hyperdrive-protocol
Code for review
https://github.com/delvtech/hyperdrive-frontend/tree/main/apps/hyperdrive-trading
Team information
Company: DELV
Official website: https://delv.tech/
Point of contact: Charles St. Louis
Email/Telegram: [email protected]
The text was updated successfully, but these errors were encountered: