Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-swap transfers emit unnecessary warning logs #1952

Open
iamacook opened this issue Sep 24, 2024 · 0 comments
Open

Non-swap transfers emit unnecessary warning logs #1952

iamacook opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@iamacook
Copy link
Member

Description

In general, we decode/map swap transfers before "standard" ones. An inherent check for whether a transfer is swap related is checking whether the transaction interacts with the settlment contract. If it doesn't, we throw and the transaction is later mapped as a "standard" transfer.

In general, the throwing behaviour matches the pattern for all "external" mapping, e.g. swaps, TWAPs and staking. However, this is logging for every non-settlement contract-based transfer.

Reproduction steps

  1. Open a Safe with a non-swap-based transfer.
  2. Observe warning.

Expected behavior

No warning is emitted for non-swap-based transfers.

Additional information

Possible solutions: we either don't warn about this, or hoist the settlement contract check and only call mapSwapTransferInfo if it is indeed interacting with it.

@iamacook iamacook added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant