Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Remove FakeCacheService #1960

Open
hectorgomezv opened this issue Sep 25, 2024 · 0 comments
Open

[Tech Debt] Remove FakeCacheService #1960

hectorgomezv opened this issue Sep 25, 2024 · 0 comments

Comments

@hectorgomezv
Copy link
Member

hectorgomezv commented Sep 25, 2024

Description

FakeCacheService was introduced to mimic the behavior of a Cache layer while running unit tests. One of its main goals was to avoid the need for having a running cache instance (Redis) while running the unit tests. This is not true anymore since the CGW does require a running Redis instance for some test suites (e.g.: redis.cache.service.spec.ts).

Moreover, there are no strict guarantees that the actual Redis behavior is mimicked by FakeCacheService, making this class a risk since bugs can be introduced unnoticed while using this class on tests.

Requirements

  • Remove FakeCacheService.
  • Replace FakeCacheService usages on test classes by RedisCacheService.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant