Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map beaconChainExplorerUriTemplate property #1976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamacook
Copy link
Member

Summary

Resolves #1974

In order to make the beacon chain explorer URL dynamic for clients, a new beaconChainExplorerUriTemplate property has been added to the Config Service.

This validates and maps the value on the relevant layers.

Changes

  • Add new BeaconChainExplorerUriTemplateSchema and infer entity from it.
  • Add new entity to ChainSchema.
  • Map property accordingly.
  • Add relative builder.
  • Add/update tests accordingly.

@iamacook iamacook self-assigned this Sep 30, 2024
@iamacook iamacook requested a review from a team as a code owner September 30, 2024 09:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11102883815

Details

  • 9 of 12 (75.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 90.859%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/chains/entities/beacon-chain-explorer-uri-template.entity.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 11102081679: -0.007%
Covered Lines: 8436
Relevant Lines: 8915

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Beacon Chain explorer from Config Service
2 participants