Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research globally handling of viem errors #1985

Open
iamacook opened this issue Oct 1, 2024 · 0 comments
Open

Research globally handling of viem errors #1985

iamacook opened this issue Oct 1, 2024 · 0 comments

Comments

@iamacook
Copy link
Member

iamacook commented Oct 1, 2024

Description

In general, we have a pattern whereby we don't expose external packages beyond the datasource layer. This not only allows interchanability, but also consistent error handling.

Due to the extensive functionality of viem, it is the only package that doesn't follow this pattern. We have already seen two instances where this has thrown unknown errors, breaking the UI:

We should investigate wrapping viem with consistent error handling, not using the package directly.

Requirements

  • Assert the best way to wrap viem. (Defining our own interface for this would be tedious, but possible.)
  • If viable, wrap viem accordingly.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant