Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe-events-service to infrastructure #100

Closed
3 tasks done
moisses89 opened this issue Jul 10, 2023 · 4 comments · Fixed by #117
Closed
3 tasks done

Add safe-events-service to infrastructure #100

moisses89 opened this issue Jul 10, 2023 · 4 comments · Fixed by #117
Assignees
@moisses89

Comments

@moisses89
Copy link
Member

moisses89 commented Jul 10, 2023 •
edited
Loading

Description

This issue is created to add to safe-infrastructure the new safe-events https://github.com/safe-global/safe-events-service.

Tasks
@moisses89 moisses89 assigned moisses89 and unassigned moisses89 Jul 10, 2023
@moisses89
Copy link
Member Author

Marked as blocked until add the new client-gateway #99

@moisses89 moisses89 self-assigned this Aug 14, 2023
@moisses89 moisses89 removed the blocked label Oct 2, 2023
@Uxio0
Copy link
Member

Uxio0 commented Oct 2, 2023

This should be unlocked now

@moisses89
Copy link
Member Author

moisses89 commented Oct 2, 2023 •
edited
Loading

@Uxio0 I'm taking a look and I'm having issues enabling admin of events service behind a custom path as for example /evs/admin, because the root path of the app is '/' instead 'evs'.
The same is nehaviour is happening with swagger.
I could see that the config service and the transaction service have an environment variable to define the root path of every endpoint. FORCE_SCRIPT_NAME=/cfg/
Could we do the same on safe-events-service?

@Uxio0 Uxio0 changed the title Add safe-events-service Add safe-events-service to infrastructure Oct 3, 2023
@moisses89 moisses89 mentioned this issue Oct 3, 2023
Closed
@moisses89
Copy link
Member Author

I just created an issue safe-global/safe-events-service#92 this should be done first

@moisses89 moisses89 mentioned this issue Oct 3, 2023
Merged
@moisses89 moisses89 removed the blocked label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moisses89 moisses89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Safe events service safe-global/safe-infrastructure
2 participants
@Uxio0 @moisses89