Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Safe events service #117

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Add Safe events service #117

merged 4 commits into from
Oct 5, 2023

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Oct 3, 2023 •
edited
Loading

Closes #100
Closes #113

  • Update Readme and add diagrams section to store raw diagrams and picture diagrams.
  • Update local instructions to use safe-events-service to send webhooks instead transaction service.
  • Add safe-events-service and dependencies to docker-compose file.
  • Add default environment variables for safe-events-service.

@moisses89 moisses89 marked this pull request as ready for review October 4, 2023 13:23
@moisses89 moisses89 requested a review from a team as a code owner October 4, 2023 13:23
@moisses89 moisses89 requested review from fmrsabino, Uxio0 and iamacook and removed request for a team October 4, 2023 13:23
@moisses89
Copy link
Member Author

@Uxio0 this PR is ready for review, but we shouldn't merge it until get the version 0.5.0 of safe-events-service.

@moisses89 moisses89 changed the title WIP Add safe events service Add safe events service Oct 4, 2023
@moisses89 moisses89 changed the title Add safe events service Add Safe events service Oct 4, 2023
@Uxio0
Copy link
Member

Uxio0 commented Oct 4, 2023

Depends on safe-global/safe-events-service#96

Uxio0
Uxio0 requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just some small naming requests

.env.sample Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/nginx/nginx.conf Outdated Show resolved Hide resolved
docs/running_locally.md Outdated Show resolved Hide resolved
docs/running_locally.md Show resolved Hide resolved
@moisses89 moisses89 merged commit 746a8c0 into main Oct 5, 2023
2 checks passed
@moisses89 moisses89 deleted the add_safe_events_service branch October 5, 2023 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino is a code owner automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook is a code owner automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
Don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update diagram of infrastructure Add safe-events-service to infrastructure
2 participants
@moisses89 @Uxio0