Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional steps to fully launch on a new chain #133

Open
svanegmond opened this issue Mar 15, 2024 · 4 comments
Open

Additional steps to fully launch on a new chain #133

svanegmond opened this issue Mar 15, 2024 · 4 comments

Comments

@svanegmond
Copy link

svanegmond commented Mar 15, 2024

I wanted to provide some notes on what we went through deploying Safe, finally, on the Shyft network, in addition to the steps described to add an official entry in safe-deployments.

I'm not sure that these are sensible as a PR, except maybe safe-global/safe-transaction-service#3:

  1. Nethermind requires additional configuration settings besides just turning off pruning. Bug filed separately about that.
  2. We had to add an entry to cgw.env mapping the chain ID for our chain to the name it is known as at coingecko: prices.chains.7341.nativeCoin=SHFT This was incredibly difficult to figure out.
  3. The default nginx 502 error page is unsightly, and is shown for several minutes while the ui server does a build and run (!). Separately, the chain logo is not kept in the docker image we upload it to. These changes address this point:

docker-compose.yml:

add to cfg-web volumes:
      - ./docker/media_chains:/app/staticfiles/chains/

add to nginx volumes:
      - ./docker/pages:/pages

revise docker/nginx/nginx.conf:

server {
...
    error_page 500 502 503 504 /500.html ;
    location /500.html {
        root /pages/;
    }
    location /cfg/media {
        alias /nginx-cfg/staticfiles/chains;
    }
...
}

Create docker/pages/500.html with the desired 500 error page and docker/media_chains/7341/currency_logo.png (where 7341 is our chain ID) with our chain logo.

Manually log into the cfg-db container, and revise the logo. This is not possible with the django UI as it is.
update chains_chain set chain_logo_uri='7341/currency_logo.png' where id=7341

@moisses89
Copy link
Member

Thanks for the feedback, we really apreciate it.
Could you link the bug issue that you mentions in the point 1?

@svanegmond
Copy link
Author

Yes. That's safe-global/safe-docs#434

@bertux
Copy link

bertux commented Apr 28, 2024

When I tried on my install without uploading manually the logo and updating manually the database, I can't configure anymore a chain because it throws the error [Errno 2] No such file or directory: '/app/src/media/chains/10242/currency_logo_fETmRCD.png' so it confirms it's not possible to upload the logo with the Django UI but I didn't expect it to break the possibility to configure the chain.

@bertux
Copy link

bertux commented Apr 28, 2024

I've made it for the logo without modifying cfg-web by just modifying nginx configuration to serve /cfg/media/chains from a new media-chains mounted volume added in docker-compose.yml
I will create a PR for that to let others review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants