Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3406, GH-3427 update libs #3426

Merged
merged 3 commits into from
Jun 14, 2024
Merged

GH-3406, GH-3427 update libs #3426

merged 3 commits into from
Jun 14, 2024

Conversation

DmitryBespalov
Copy link
Contributor

@DmitryBespalov DmitryBespalov commented Jun 12, 2024

Handles #3406

Changes proposed in this pull request:

  • Update to a new URRegistry version

Handles #3427

  • Added password strength meter and minimum password requirements
  • Changed texts in description of the export/import screens

@DmitryBespalov DmitryBespalov self-assigned this Jun 12, 2024
* Added password strength requirements and meter
* Changed texts in instructions and success screens
@DmitryBespalov DmitryBespalov changed the title GH-3406 update libs GH-3406, GH-3427 update libs Jun 13, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 8.10%. Comparing base (a27a958) to head (00c24a4).
Report is 14 commits behind head on main.

Files Patch % Lines
...ta Export/CreateExportPasswordViewController.swift 0.00% 26 Missing ⚠️
Multisig/Features/Data Export/ExportDataFlow.swift 0.00% 9 Missing ⚠️
Multisig/Features/Data Export/ImportDataFlow.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3426      +/-   ##
========================================
- Coverage   8.11%   8.10%   -0.01%     
========================================
  Files        796     796              
  Lines      44961   44996      +35     
========================================
  Hits        3648    3648              
- Misses     41313   41348      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 76008f9 into main Jun 14, 2024
3 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3406/update-libs branch June 14, 2024 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant