Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3435 changed display strings for order types #3436

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

DmitryBespalov
Copy link
Contributor

@DmitryBespalov DmitryBespalov commented Jul 2, 2024

Handles #3435

Changes proposed in this pull request:

  • changed the type logic according to the current web app's logic

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 8.10%. Comparing base (b5a5c4f) to head (15b424a).
Report is 7 commits behind head on main.

Files Patch % Lines
...rvices/Safe Client Gateway Service/SCGModels.swift 0.00% 12 Missing ⚠️
...sViewController/TransactionDetailCellBuilder.swift 0.00% 10 Missing ⚠️
...ViewController/TransactionListViewController.swift 0.00% 6 Missing ⚠️
...n/WCIncomingTransactionRequestViewController.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3436      +/-   ##
========================================
- Coverage   8.10%   8.10%   -0.01%     
========================================
  Files        796     796              
  Lines      45038   45050      +12     
========================================
  Hits        3650    3650              
- Misses     41388   41400      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 09f8f0f into main Jul 2, 2024
3 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3435/limit-order-type branch July 2, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant