not all transactions on tenderly that contain reverts are unsuccessful

[gosuto-inzasheru]

Description

we just had a tx which was being flagged as "failing" or "reverting" by the safe ui based on the tenderly sim. however, a try:catch code block in our smart contract catches that revert and thus the transaction completes successfully at the end. we executed it anyway and it went through. see https://etherscan.io/tx/0xcdc7a4f60a74671e5553f9cd234ce065c9d96e2736eddf2b52e0602f49b20035 (note the Although one or more Error Occurred [execution reverted] Contract Execution Completed)

anyway i think the checking for reverts should be a bit more specific, not all reverts mean the tx will fail. it took us a while to muster the courage to exec because of your warnings 🙂

Environment

safe v1.3.0, mainnet

Steps to reproduce

post a tx that will revert internally, but which will be caught by a try:except and thus execute succesfully. then run tenderly sim and check warning.

Expected result

less aggressive warning

Obtained result

aggressive warning (tx will fail!). not true.

Screenshots

didnt take any