Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of functions for adding/removing owners is not coherent #118

Open
Uxio0 opened this issue Aug 8, 2019 · 0 comments
Open

Naming of functions for adding/removing owners is not coherent #118

Uxio0 opened this issue Aug 8, 2019 · 0 comments
Assignees
@Uxio0
Labels
future Features for next major contract version

Comments

@Uxio0
Copy link
Member

Uxio0 commented Aug 8, 2019 •
edited
Loading

Problem

  • Function addOwnerWithThreshold allows the user to add an owner and change the threshold
  • Function removeOwner allows the user to remove an owner and change the threshold too

Solution

Either both functions have WithThreshold suffix or no one does.
@Uxio0 Uxio0 added this to the contracts-safe-1.1.0 milestone Aug 8, 2019
@Uxio0 Uxio0 self-assigned this Aug 8, 2019
Uxio0 added a commit that referenced this issue Aug 8, 2019
@Uxio0
Rename removeOwner to removeOwnerWithThreshold
a3891de 
Closes #118
@Uxio0 Uxio0 mentioned this issue Aug 8, 2019
Closed
@rmeissner rmeissner removed this from the contracts-safe-1.1.0 milestone Sep 5, 2019
@rmeissner rmeissner added the future Features for next major contract version label Apr 19, 2020
@rmeissner rmeissner added MUST and removed enhancement labels Jul 9, 2020
@rmeissner rmeissner removed the MUST label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
future Features for next major contract version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename removeOwner to removeOwnerWithThreshold safe-global/safe-smart-account
2 participants
@rmeissner @Uxio0