Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signatures that depends only on msg.sender are nonce independent. #187

Open
rmeissner opened this issue Apr 1, 2020 · 0 comments
Open

Signatures that depends only on msg.sender are nonce independent. #187

rmeissner opened this issue Apr 1, 2020 · 0 comments
Labels
documentation future Features for next major contract version

Comments

@rmeissner
Copy link
Member

rmeissner commented Apr 1, 2020 •
edited
Loading

Essentially when the msg.sender is an owner and the Safe has a threshold one, the nonce is never checked. This is because in this case the check on contract level only checks if the msg.sender is an owner, never validating the hash with the nonce.

What can happen in this case?

If we have multiple owners and threshold 1 all could send transactions at the same time, and they would all be executed.
@tschubotz tschubotz changed the title Signatures that depends only on msg.sender are nonce independant. Signatures that depends only on msg.sender are nonce independent. Apr 1, 2020
@rmeissner rmeissner added the future Features for next major contract version label Apr 19, 2020
@nicosampler nicosampler mentioned this issue May 5, 2021
Closed
@mmv08 mmv08 mentioned this issue Feb 16, 2023
Closed
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#187 from gnosis/update-deps
1c48c18 
Update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation future Features for next major contract version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmeissner