Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zkSync Support To v1.4.1 #767

Open
1 task
nlordell opened this issue Jun 21, 2024 · 0 comments
Open
1 task

Add zkSync Support To v1.4.1 #767

nlordell opened this issue Jun 21, 2024 · 0 comments
Assignees
@mmv08

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jun 21, 2024 •
edited
Loading

Context / issue

Currently, the deployment scripts for Safe contracts do not work on zkSync networks.

Proposed solution

Add support for deploying to Safe contracts to zkSync networks. Note that this identical to #766 but targetted to the v1.4.1 branch so that we can deploy that version of Safe contracts to zkSync networks.

In addition to the expected outcome of the aforementioned issue:

  • A new v1.4.1-1 release with zkSync deployment supported

Alternatives

Manually deploy the contracts. The downside of this is we explicitly want to support Hyperstack based chains, and manually deploying to each of these chains does not scale well.
@nlordell nlordell changed the title Support v1.4.1 Deployments to zkSync Chains Add zkSync Support To v1.4.1 Jun 21, 2024
@mmv08 mmv08 mentioned this issue Sep 2, 2024
Merged
@mmv08 mmv08 self-assigned this Sep 9, 2024
@mmv08 mmv08 mentioned this issue Sep 18, 2024
Merged
mmv08 added a commit that referenced this issue Sep 19, 2024
@mmv08
Update SafeMigration tests for zkSync (#833)
70673bb 
This PR:
- Partially solves
#767 (test
updates for `SafeToL2Upgrade` are still pending)
- It is based on version 1.5.0 because 1.4.1 cannot be compiled at the
moment because we used `.send` in there, and hardhat zksync compiler
plugin needs to be updated to support suppressing errors. I will
cherry-pick it later.
- I updated the `deployContract` function name and return type to be
more self-explanatory
- The main changes were around adding zksync compatible bytecode and
also using the ContractFactory from the "zksync-ethers" package because
in ZkSync you need to interact with a system contract to deploy
contracts and not just send a transaction with the bytecode and
`to` address omitted.

One bug found: matter-labs/hardhat-zksync#1420
@mmv08 mmv08 mentioned this issue Sep 19, 2024
Merged
mmv08 added a commit that referenced this issue Sep 20, 2024
@mmv08
Add zkSync support to SafeToL2Migration tests (#834)
1cec0e7 
This PR:
- Almost Implements #767 by applying the same principles to
SafeToL2Migration tests as in
#833
- I will cherry-pick the changes back to 1.4.1 branch once the hardhat
compiler plugin issue is addressed
mmv08 added a commit that referenced this issue Sep 26, 2024
@mmv08
Update SafeMigration tests for zkSync (#833)
855b6fd 
This PR:
- Partially solves
#767 (test
updates for `SafeToL2Upgrade` are still pending)
- It is based on version 1.5.0 because 1.4.1 cannot be compiled at the
moment because we used `.send` in there, and hardhat zksync compiler
plugin needs to be updated to support suppressing errors. I will
cherry-pick it later.
- I updated the `deployContract` function name and return type to be
more self-explanatory
- The main changes were around adding zksync compatible bytecode and
also using the ContractFactory from the "zksync-ethers" package because
in ZkSync you need to interact with a system contract to deploy
contracts and not just send a transaction with the bytecode and
`to` address omitted.

One bug found: matter-labs/hardhat-zksync#1420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlordell @mmv08