Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error propagation for internal TX #839

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Error propagation for internal TX #839

merged 2 commits into from
Sep 30, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Sep 30, 2024

Fixes #715

This PR implements error propagation for internal TX so the user/dev can know the reason for revert instead of generic GS013.

@remedcu remedcu self-assigned this Sep 30, 2024
@coveralls
Copy link

coveralls commented Sep 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11102102791

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.581%
Totals Coverage Status
Change from base Build 11072497505: 0.01%
Covered Lines: 397
Relevant Lines: 409
💛 - Coveralls

mmv08
mmv08 reviewed Sep 30, 2024
View reviewed changes
contracts/Safe.sol Outdated Show resolved Hide resolved
@remedcu remedcu requested a review from mmv08 September 30, 2024 08:21
mmv08
mmv08 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Does this PR mean that the wallet/contracts team decided to implement the change?

@remedcu
Copy link
Member Author

remedcu commented Sep 30, 2024

Does this PR mean that the wallet/contracts team decided to implement the change?

Yes

@remedcu remedcu merged commit 0142ec8 into main Sep 30, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@mmv08 mmv08 deleted the error-propagation branch September 30, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@akshay-ap akshay-ap Awaiting requested review from akshay-ap

Assignees

@remedcu remedcu

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose revert message when internal transaction fails and safeTxGas/gasPrice are 0
3 participants
@remedcu @coveralls @mmv08