Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership change events after setup within same tx not being picked up #1635

Closed
tolbrino opened this issue Aug 22, 2023 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@tolbrino
Copy link

We are experiencing issues deploying Safe instances through our factory contract. Here is an example:

https://gnosisscan.io/tx/0x66425f06902a0ffc50d041599e60830d94d666c433e603095d03fca5897673b7#eventlog

The problem is that the tx service endpoint /owners/MY_ACCOUNT/safes won't return the newly created Safe. We tracked down the issue further and believe the problem lies in the switch of ownership during the deployment. This does not seem to be picked up by the indexer and it continues to "believe" the Safe is owned by our factory contract.

@tolbrino tolbrino added the bug Something isn't working label Aug 22, 2023
@QYuQianchen
Copy link

QYuQianchen commented Aug 22, 2023

To give a little bit more context: When a safe proxy is created with createProxyWithNonce, the sole owner is set to the msg.sender which is a factory contract (StakeFactory). Within the same transaction, after a few other internal transactions, the owner of the safe proxy is swapped to a different EOA address.

Given the owner of the safe proxy is a contract, the signature generation follows EIP-1271, i.e. approveHash then execTransaction. Payload of the swapOwner safe transaction is thus encoded in execTransaction.

What we've observed is that, for the said proxy creation call, in the safe-transaction-service, only setup and approveHash internal calls got indexed.

@moisses89
Copy link
Member

Maybe is related with the contract version, we are currently working adding support for 1.4.1 version #1433

@Uxio0
Copy link
Member

Uxio0 commented Sep 29, 2023

As @moisses89 states, it would be important also to know what versions are you using of the contracts, as service should not have any problem detecting owner swap

@Uxio0
Copy link
Member

Uxio0 commented Oct 16, 2023

Could you provide more feedback about this issue?

@QYuQianchen
Copy link

Hi there. Sorry that the thread got lost. We use contracts of v1.4.1

@safe-global safe-global deleted a comment Oct 17, 2023
@JagoFigueroa
Copy link

Sorry for the delay guys. I see that the issue is resolved now so I will go ahead and close the ticket. Please let us know if you are still experiencing any issues 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants