Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitise chain-specific store entries according to supported chains #2585

Open
iamacook opened this issue Oct 4, 2023 · 1 comment
Open

Comments

@iamacook
Copy link
Member

iamacook commented Oct 4, 2023

What is the feature about

We are indefinitely persisting added Safes, the address book, pinned Safe apps and likely others, regardless of currently supported chains. If chain support is deprecated, these entries remain.

As services associated with deprecation are removed, this can cause issues down the line, e.g. #2584. We should sanitise the local state in accordance with the supported chains. However, we need to consider that removing store entries is not reversible.

@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Oct 4, 2023
@usame-algan
Copy link
Member

We could have a "safe read local storage" where we filter out unsupported chains whenever they are read instead of removing them from the users local storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New issues
Development

No branches or pull requests

3 participants