Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fileverse Safe App] Relaying doesn't work with W3A #3079

Closed
kirkkonen opened this issue Jan 8, 2024 · 5 comments
Closed

[Fileverse Safe App] Relaying doesn't work with W3A #3079

kirkkonen opened this issue Jan 8, 2024 · 5 comments

Comments

@kirkkonen
Copy link

kirkkonen commented Jan 8, 2024

Bug description

When relaying a Safe App transaction with a social wallet, nothing happens.

Environment

  • Browser: Chrome
  • Wallet: W3A
  • Chain: Gnosis Chain

Steps to reproduce

  1. Login with W3A/Google
  2. Go to a Safe App (e.g. Fileverse)
  3. Create a transaction
  4. Try executing the tx via the Relayer

Expected result

Tx should be executed or at least some meaningful error shown

Obtained result

Absolutely nothing happens

Screenshots

https://www.loom.com/share/15d82c90928541d98acdd7316d07ca95?sid=7cf6666d-bd97-4f45-82ce-1e6d0a1593da


Original report from Fileverse

Context can be found here: https://5afe.slack.com/archives/C03DAGWJCR5/p1700575086865789

  1. Relayer Provider cancelling txns.
    -> Loom: https://www.loom.com/share/15d82c90928541d98acdd7316d07ca95?sid=7cf6666d-bd97-4f45-82ce-1e6d0a1593da
    -> Logjam with proper console logs & api calls: https://jam.dev/c/b2c2134f-3c8e-4a44-bdb2-94032accb649
  2. UI becoming unusable by not allowing users to click.
    Log jam to help you investigate: https://jam.dev/c/e3f93c77-4abb-4e17-b81c-2e54274a7839
    Safe tx hash (failed):
    0x71b7628233bdbc1163ce5eda9a0c83dfab62773c5b906edb20e995bd8c9f4d74
    All the API calls are also recorded in the logjam link for you to debug if issue is on the API Level. For eg, go the request you want to check in bottom right on this link: https://jam.dev/c/b2c2134f-3c8e-4a44-bdb2-94032accb649

And a successful one (if the relayer is not used): https://gnosisscan.io/tx/0xb2f23c467a42bc397ea20b40b57a509937b3a0729623944b95c7897595a0b962/

@kirkkonen kirkkonen converted this from a draft issue Jan 8, 2024
@katspaugh
Copy link
Member

katspaugh commented Jan 8, 2024

@kirkkonen from reading this issue it’s not really clear what needs to be done.

Please write a more succinct problem description and paste all the necessary info in the issue so that we don’t have to dig on slack.

Tip: if you start creating an issue from GitHub directly instead of the project board, there’s a helpful bug report template.

@kirkkonen
Copy link
Author

Just found this comment. Kinda weird to put it on ice because you have to make 1 click to get into the Slack thread but I'll copy the original message for you here. I don't have any other context. Added you to the Telegram chat either. @katspaugh

Last week I got some more context on the bug reported by the Fileverse team. Quick facts:
They face relayer error on deploying a Collaboration smart contract (portal)
That's happening on Gnosis chain, not Goerli
It is definitely unrelated to Seedless as it happened and was reported way before the release
Some more details shared by Constantin from Fileverse:
(1) This is the Fileverse App on Safe: https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fportal.fileverse.io&chain=gno

  • Fileverse = collaboration smart contract deployed on Gnosis
  • On the Safe App, it's also only available for Safe on Gnosis

(2) In both the above error messages / relayer transaction issues, the users clicked on the Fileverse App and when deploying it they faced this relayer specific issue

  • To help, we tried to replicate from our side and we got the same issue for this flow: "google login". Here's a jam screenrecoding that I just did with my gmail and it shows you the screen + console errors directly: https://jam.dev/c/f628336d-5514-4f10-8d9d-6dd7cf185b79
  • Check 0:51

@katspaugh
Copy link
Member

It looks like an issue with the combination of relaying and W3A.

@liliya-soroka @francovenica it's not a known bug, is it? Can you reproduce any problems when relaying with the social login?

@katspaugh katspaugh moved this from New issues to Ready for QA in Safe{Wallet} Feb 6, 2024
@katspaugh katspaugh changed the title Error on deploying a Fileverse Safe on Gnosis chain via relayer Relaying doesn't work with W3A Feb 6, 2024
@katspaugh katspaugh changed the title Relaying doesn't work with W3A [Fileverse Safe App] Relaying doesn't work with W3A Feb 7, 2024
@liliya-soroka
Copy link
Member

liliya-soroka commented Feb 7, 2024

I can not reproduce the issue .
The portal was deployed successfully for my gnosis chain safe using Social Login + Relay / MM +Relay

@katspaugh katspaugh moved this from Ready for QA to Todo in Safe{Wallet} Feb 7, 2024
@katspaugh katspaugh moved this from Todo to New issues in Safe{Wallet} Mar 22, 2024
@usame-algan
Copy link
Member

Can this issue be closed since social wallet was sunset?

@katspaugh katspaugh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@github-project-automation github-project-automation bot moved this from New issues to Done in Safe{Wallet} Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants