Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tenderly simulation to signers ahead of signing #3592

Closed
tomislavmamic opened this issue Apr 19, 2024 · 4 comments
Closed

Enable Tenderly simulation to signers ahead of signing #3592

tomislavmamic opened this issue Apr 19, 2024 · 4 comments

Comments

@tomislavmamic
Copy link

What is the feature about

When using more complex tools, like Jumper Exchange, Safe doesn't show enough information to the signers. If they want to review where the money is actually going, they can't. Tenderly review shows this, albeit in a bit complex way. I propose you make it possible to simulate transaction if executed by any signer.

The list of requirements

Designs/sketches

Links

@katspaugh
Copy link
Member

Not sure I follow. You can simulate with Ternderly when both signing and executing.

Screenshot 2024-04-22 at 12 03 28

@katspaugh katspaugh closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@tomislavmamic
Copy link
Author

CleanShot 2024-04-24 at 11 08 43@2x
Aaah sorry, for some reason I missed this link

@katspaugh
Copy link
Member

cc @TanyaEfremova maybe it make more sense to move that link to the Simulation block itself. It's just one line.

@TanyaEfremova
Copy link
Contributor

@katspaugh Since both Redefine and Tenderly notifications are shown on the right side, I'll have to review both first to keep things consistent. Thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants