Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: top 5 assets on the dashboard #3796

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Feat: top 5 assets on the dashboard #3796

merged 8 commits into from
Jun 5, 2024

Conversation

katspaugh
Copy link
Member

What it solves

A helpful widget to get a quick glance at Safe's assets + promote the Swaps feature on the Dashboard.

Screenshot 2024-06-04 at 13 31 40

@katspaugh katspaugh requested a review from compojoom June 4, 2024 11:34
Copy link

github-actions bot commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jun 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 950.04 KB (-32 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.4 KB (🟡 +148 B) 979.44 KB
/home 58.68 KB (🟡 +1.22 KB) 1008.72 KB
/settings/security 8.45 KB (🟢 -5 B) 958.49 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.48% (+0.03% 🔼)
11309/14228
🔴 Branches
58.42% (+0.01% 🔼)
2703/4627
🟡 Functions
66.63% (+0.07% 🔼)
1821/2733
🟢 Lines
80.86% (+0.02% 🔼)
10199/12613
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / SendButton.tsx
100% 50% 50% 100%

Test suite run success

1438 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 3a95838

@francovenica
Copy link
Contributor

francovenica commented Jun 4, 2024

The list doesn't take in account if tokens were hidden in the assets tab:
image
image

Suggestion:
Adding an empty state, so if you have no tokens in the safe it doesn't show an empty native token at the top.
top assets

Suggestion 2:
In networks where the swap feature is not available no swap button is shown (which is correct), but makes the widget less useful. Maybe the "Send" button can be put there for those networks.

@katspaugh
Copy link
Member Author

Done, @francovenica 👍

@francovenica
Copy link
Contributor

Looks good! approved

@katspaugh katspaugh merged commit 3a93685 into dev Jun 5, 2024
13 of 14 checks passed
@katspaugh katspaugh deleted the top-assets branch June 5, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants