Bug chain prefix toggle #4271
Merged
Bug chain prefix toggle #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
@Arya-A-Nair code looks good, thanks! Could you sign the CLA? |
usame-algan
approved these changes
Oct 1, 2024
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Safe-infra
added a commit
to safe-global/cla-signatures
that referenced
this pull request
Oct 2, 2024
|
@usame-algan i have signed the CLA |
|
@usame-algan I have signed the CLA can you please merge the PR |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR has been raised to resolve the issue #4261. The
Resolves the issue of the chain prefix before the address
How this PR fixes it
This pr fixes it by passing the prefix as a prop to the component
How to test it
Click on the QR code and try to switch the toggle, you can see the difference in the address displayed below
Screenshots
While toggle on-
While toggle off-
Checklist