-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Batch icon in dark mode #4516
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1014.34 KB (🟡 +270 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1619 tests passing in 217 suites. Report generated by 🧪jest coverage report action from 43db540 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Team, we have a smoke test failed. This is directly related to the change in this PR. I fixed it yesterday evening though already. Please invest some time to review the tests before merging. @francovenica @usame-algan @compojoom CC: @liliya-soroka |
What it solves
Resolves #4384
How this PR fixes it
SvgIcon
to insert batch icon in transactions listHow to test it
Screenshots
Checklist