From a9b2ccf70a5e92e79119321595778ca022a31ee8 Mon Sep 17 00:00:00 2001 From: Matthias Koeppe Date: Tue, 25 Jun 2024 17:34:46 -0700 Subject: [PATCH] Deprecations --- src/sage/schemes/generic/divisor.py | 8 ++++++++ src/sage/schemes/toric/chow_group.py | 8 ++++++++ src/sage/schemes/toric/divisor.py | 8 ++++++++ src/sage/schemes/toric/variety.py | 8 ++++++++ 4 files changed, 32 insertions(+) diff --git a/src/sage/schemes/generic/divisor.py b/src/sage/schemes/generic/divisor.py index d46b8caff0e..981290dfe76 100644 --- a/src/sage/schemes/generic/divisor.py +++ b/src/sage/schemes/generic/divisor.py @@ -111,10 +111,18 @@ def is_Divisor(x): sage: x,y = AffineSpace(2, GF(5), names='xy').gens() sage: C = Curve(y^2 - x^9 - x) sage: is_Divisor(C.divisor([])) + doctest:warning... + DeprecationWarning: The function is_Divisor is deprecated; + use 'isinstance(..., Divisor_generic)' instead. + See https://github.com/sagemath/sage/issues/38277 for details. True sage: is_Divisor("Ceci n'est pas un diviseur") False """ + from sage.misc.superseded import deprecation + deprecation(38277, + "The function is_Divisor is deprecated; " + "use 'isinstance(..., Divisor_generic)' instead.") return isinstance(x, Divisor_generic) diff --git a/src/sage/schemes/toric/chow_group.py b/src/sage/schemes/toric/chow_group.py index f3225661c10..de2441eef0f 100644 --- a/src/sage/schemes/toric/chow_group.py +++ b/src/sage/schemes/toric/chow_group.py @@ -1244,10 +1244,18 @@ def is_ChowCycle(x) -> bool: sage: A = P2.Chow_group() sage: from sage.schemes.toric.chow_group import * sage: is_ChowCycle(A) + doctest:warning... + DeprecationWarning: The function is_ChowCycle is deprecated; + use 'isinstance(..., ChowCycle)' instead. + See https://github.com/sagemath/sage/issues/38277 for details. False sage: is_ChowCycle(A.an_element()) True sage: is_ChowCycle('Victoria') False """ + from sage.misc.superseded import deprecation + deprecation(38277, + "The function is_ChowCycle is deprecated; " + "use 'isinstance(..., ChowCycle)' instead.") return isinstance(x, ChowCycle) diff --git a/src/sage/schemes/toric/divisor.py b/src/sage/schemes/toric/divisor.py index c66bf21a3a0..af5efa5fc2d 100644 --- a/src/sage/schemes/toric/divisor.py +++ b/src/sage/schemes/toric/divisor.py @@ -207,6 +207,10 @@ def is_ToricDivisor(x): sage: from sage.schemes.toric.divisor import is_ToricDivisor sage: is_ToricDivisor(1) + doctest:warning... + DeprecationWarning: The function is_ToricDivisor is deprecated; + use 'isinstance(..., ToricDivisor_generic)' instead. + See https://github.com/sagemath/sage/issues/38277 for details. False sage: P2 = toric_varieties.P2() sage: D = P2.divisor(0); D @@ -214,6 +218,10 @@ def is_ToricDivisor(x): sage: is_ToricDivisor(D) True """ + from sage.misc.superseded import deprecation + deprecation(38277, + "The function is_ToricDivisor is deprecated; " + "use 'isinstance(..., ToricDivisor_generic)' instead.") return isinstance(x, ToricDivisor_generic) diff --git a/src/sage/schemes/toric/variety.py b/src/sage/schemes/toric/variety.py index c1ca8351263..0c315be0fa9 100644 --- a/src/sage/schemes/toric/variety.py +++ b/src/sage/schemes/toric/variety.py @@ -3305,12 +3305,20 @@ def is_CohomologyClass(x): sage: HH = P2.cohomology_ring() sage: from sage.schemes.toric.variety import is_CohomologyClass sage: is_CohomologyClass( HH.one() ) # needs sage.libs.singular + doctest:warning... + DeprecationWarning: The function is_CohomologyClass is deprecated; + use 'isinstance(..., CohomologyClass)' instead. + See https://github.com/sagemath/sage/issues/38277 for details. True sage: is_CohomologyClass( HH(P2.fan(1)[0]) ) # needs sage.libs.singular True sage: is_CohomologyClass('z') False """ + from sage.misc.superseded import deprecation + deprecation(38277, + "The function is_CohomologyClass is deprecated; " + "use 'isinstance(..., CohomologyClass)' instead.") return isinstance(x, CohomologyClass)