SCSI.WriteSame10.Unmap fails with devices with 4kB sectors (or bigger)

[folkertvanheusden]

At some point, SCSI.WriteSame10.Unmap wants to read 65 sectors. With 4 kB sectors, that is 266240 bytes.
In lib/init.c the following parameters are set:

       iscsi->max_burst_length                       = 262144;
       iscsi->first_burst_length                     = 262144;
       iscsi->initiator_max_recv_data_segment_length = 262144;

Now 266240 > 262144 and thus the test will fail not because of the unmap handling but because of the 4kB sector size.

For me I worked around this by setting these parameters to 524288 but ideally these parameters can be set via a library-call.

regards

[sahlberg]

I can not reproduce the failure. I have a 4k thin provisioned LUN and the test passes.
Those three arguments in iscsi should not affect reading from the device. They only control the maximum size of each blob that is sent.
A read that is bigger than this will still work, it just needs multiple roundtrips in order to get all the data across but that should be
transparent to the caller of READ10.

How does it fail? and how big is your LUN and what is the tarrget?