Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sajari/react-search-ui does not list classnames as a dependency #882

Open
neongreen opened this issue Jan 1, 2024 · 1 comment
Open

Comments

@neongreen
Copy link

@sajari/react-search-ui uses import ... 'classnames', but doesn't list it in its dependencies — I suppose it assumes it can get it by virtue of having it as a dependency of @sajari/react-components.

However, this is not the case when using eg. Yarn with nodeLinker: pnpm, or maybe even default Yarn. A package depending on @sajari/react-search-ui will fail to build. At least for me it does.

I think @emotion/css and @emotion/core dependencies should also be added.

image
@neongreen
Copy link
Author

NB: I think if you switch nodeLinker to pnp/pnpm, Yarn will tell you which dependencies have to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant