SAK-50454 Polls improve voting ui responsiveness #12856
Conversation
|
|
||
| <p class="act"> | ||
| <p class="act" style="flex-wrap:nowrap;"> |
There was a problem hiding this comment.
Thanks! I updated the code with a bootstrap class instead.
ern
changed the title
| @@ -108,9 +109,9 @@ <h1 rsf:id="poll-list-title">Polls</h1> | |||
| </td> | |||
| </tr> | |||
| </tbody> | |||
| </table> | |||
| </table></div> | |||
There was a problem hiding this comment.
Nice work! Just a quick suggestion: placing </table> and </div> on separate lines improves readability and maintainability. Could you adjust the formatting?
Removed redundant javascript script types Indented all the markup properly We need to remove those vula references at some point :)
There was a problem hiding this comment.
I've added another commit. Don't be afraid to remove redundant code, like the javascript script type on script tags. If I'm working in a file and I see old stuff that might not actually be related to the thing I'm fixing, I will still clean it up. That way our codebase steadily improves. Don't go crazy and start looking at the entire polls tool, but changes to the area where you're working are fine.
There was a problem hiding this comment.
Looks good overall! However, I noticed there's no i18n support, @adrianfish Is it okay?
@Sharadhi98 , please test one last time with the latest changes, and once everything looks good, we can merge. Thanks!
| </div> | ||
| </body> | ||
| </html> | ||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> |
There was a problem hiding this comment.
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> | |
| <!DOCTYPE html> |
For some reason, I'm unable to test the Polls tool. Even though there's are no compilation errors, I get an error when I load the tool on my local. Here's a screenshot. |
Co-authored-by: Kunal Jaykam <[email protected]>
ern
changed the title
ern
changed the title
|
@Sharadhi98 I'll pull your branch again and test things out. If it's all good, I'll approve it and merge. |
I have resolved the responsiveness issue of the polls tool by using table-responsive. I observed that the grid system applied to the portal-main-container was interfering with the styling of table-responsive, so I replaced it with flex and added two classes: d-flex and flex-column.
I'd love some feedback on changing the portal-main-container from grid to flex.
Thanks!