SAK-50505 SakaiGrader don't display empty groups in the group picker #12889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
changed the title
ern
reviewed
Sep 17, 2024
| @@ -53,7 +53,7 @@ export const graderRenderingMixin = Base => class extends Base { | |||
| ${this.groups ? html` | |||
| <div class="grader-groups"> | |||
| <div>${this.i18n.group_label}</div> | |||
| <sakai-group-picker .groups=${this.groups} | |||
| <sakai-group-picker .groups=${this.groups.filter(group => group.users && group.users.length > 0)} | |||
There was a problem hiding this comment.
is this doing the opposite of what the title of the PR says?
There was a problem hiding this comment.
@ern It could be, depending on how this is understood. For me, it's correct. The change proposes that the groups available in the group selector should only be those that have students (thereby filtering out the empty ones).
There was a problem hiding this comment.
@st-manu I'd put your groups filter into the data mixin, where the groups data is set. Less logic in the templates is usually better.
adrianfish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.