Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for top-level file comments #147

Open
bradryanbice opened this issue Mar 30, 2018 · 3 comments
Open

Allow for top-level file comments #147

bradryanbice opened this issue Mar 30, 2018 · 3 comments

Comments

@bradryanbice
Copy link

A file generated by Theo can't have documentation comments (as far as I know.)

Maybe institute a comments key in the global area, like so?

global:
  category: 'web'
  type: 'color'
  comments: 'This would be a commented out line that would appear at the top of the file.'
@aputinski
Copy link
Contributor

Right now this is not supported. The global property is merged into each token, so we'd need to figure out some other way. Since token files are ultimately all flattened together when imported, maybe this could be an option that get's passed in when calling theo.convert().

@RVledder
Copy link
Contributor

How about the following format:

example.yml

meta: 
  name: "optional name"
  description: "comment or multiline comment here"

This way in the output file, when set it would get separators of each file section based on whether the meta info has been filled in or not.

My specific use case would be to set a comment in the first base SCSS file to notify users that it's a generated file and should not edit directly.

Thoughts?

@ranzolinrafa
Copy link

Hello! We have some status update for this enhancement? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants