Notifications.delete_notification_subscription() need to be grantless operation

[ryoji-san]

Describe the bug
Notifications.delete_notification_subscription() method need to use self._request_grantless_operation() method

[saleweaver]

Hi,

no it doesn't. There's a working test for the method, and I've just tried it. It works as is.

If you add some code maybe I can help.

[ryoji-san]

Oh,, sorry, it doesn't work..

[saleweaver]

Yeah, both are unauthorized. Is this a subscription your app has created? Does creating subscriptions work?

[ryoji-san]

Yes, subscription is working and get_subscription response is below.

{
  "payload": {
    "subscriptionId": "44e8efe0-3f02-4536-8998-99b6xxxxxxxx",
    "destinationId": "0aaa84c1-d921-46f0-beba-f3973xxxxxxx",
    "payloadVersion": "1.0",
    "processingDirective": null
  },
  "errors": null,
  "pagination": null,
  "headers": {
    "Date": "Sun, 06 Feb 2022 10:08:57 GMT",
    "Content-Type": "application/json",
    "Content-Length": "184",
    "Connection": "keep-alive",
    "x-amzn-RequestId": "84dec32c-f2f0-4e91-a8d5-bd38ff14168c",
    "x-amz-apigw-id": "NHWo7EzBvHcFW-g=",
    "X-Amzn-Trace-Id": "Root=1-61ff9e38-34cd56fc5200d5946d1dec8f"
  },
  "rate_limit": null,
  "next_token": null,
  "kwargs": {}
}

I'll check it on tomorrow.
It's already nighttime in Japan.

[saleweaver]

That's weird. I've checked it all in the US marketplace, everything seems to work from the api side.

[ryoji-san]

In the end, it didn't work in the Japanese marketplace, so I made the following code and it works.

from sp_api.base.helpers import sp_endpoint, fill_query_params
from sp_api.base import ApiResponse
from sp_api.api import Notifications
from sp_api.base.exceptions import SellingApiException
from sp_api.base.marketplaces import Marketplaces

from app.conf.spapi import credentials


class DeleteNotification(Notifications):
    @sp_endpoint('/notifications/v1/subscriptions/{}/{}', method='DELETE')
    def delete_notification_subscription(self,
                                         notification_type: str,
                                         subscription_id: str,
                                         **kwargs) -> ApiResponse:
        return self._request_grantless_operation(
            fill_query_params(kwargs.pop('path'),
                              notification_type,
                              subscription_id),
            params={**kwargs})


class NotificationAPI:
    """
    SP API Notification API を呼び出すメソッドです。
    https://github.com/amzn/selling-partner-api-docs/blob/main/guides/en-US/use-case-guides/notifications-api-use-case-guide/notifications-use-case-guide-v1.md
    """

    marketplace = Marketplaces.JP

    @classmethod
    def delete_notification_subscription(cls,
                                         notification_type: str,
                                         subscription_id: str):
        """
        登録されている Subscription を削除します。
        :param subscription_id:
        :param notification_type:
        :return:
        """
        try:
            response = DeleteNotification(
                marketplace=cls.marketplace,
                credentials=credentials
            ).delete_notification_subscription(
                notification_type, subscription_id)
            return response
        except SellingApiException as e:
            return e

And it's API response is below.

{
  "payload": {},
  "errors": null,
  "pagination": null,
  "headers": {
    "Date": "Sun, 06 Feb 2022 22:25:09 GMT",
    "Content-Type": "application/json",
    "Content-Length": "8",
    "Connection": "keep-alive",
    "x-amzn-RequestId": "94171416-8716-4b8f-ae1d-dde7096ac978",
    "x-amz-apigw-id": "NJCe1GEGPHcFfcw=",
    "X-Amzn-Trace-Id": "Root=1-62004ac5-2af3df0f0f89e08e45409956"
  },
  "rate_limit": null,
  "next_token": null
}