Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancies in documentation #4

Open
sheagcraig opened this issue Oct 29, 2018 · 1 comment
Open

Discrepancies in documentation #4

sheagcraig opened this issue Oct 29, 2018 · 1 comment

Comments

@sheagcraig
Copy link

Hi there-
I was giving this a test run and came across a couple of issues.

  1. The AUTH_LDAP_TRUST_ALL_CERTIFICATES is currently mandatory. I had not set it in my settings.py, and the README says that it defaults to False, but then I got an AttributeError during an authentication attempt.
  2. The example_settings file must have an old name for the AD module (ImportError: No module named ADAuthentication). It should be server.ADConnector.ADConnector (which is correctly specified in the README).

I can do up a PR for this if needed.
@haribert
Copy link
Collaborator

haribert commented Nov 1, 2018 •
edited
Loading

Thanks for the remarks.

I currently do not have a test environment. Can you please check if the branch 4_documentation_discrepancies (in my fork) solves the mandatory AUTH_LDAP_TRUST_ALL_CERTIFICATES option?

haribert pushed a commit to haribert/sal-activedirectory that referenced this issue Nov 1, 2018
salopensource#4 Be consistent with documentation
4fcf0d7 
  * Make `AUTH_LDAP_TRUST_ALL_CERTIFICATES` optional in the code and not only in the documentation
  * Update `example_settings.py` to correct `AUTHENTICATION_BACKENDS`
* minor changes
@haribert haribert mentioned this issue Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sheagcraig @haribert