From d76533e34e6d7bc52d6bec6b5b861f94bd6bd574 Mon Sep 17 00:00:00 2001 From: Sam Ramon <15154970+samantharamon@users.noreply.github.com> Date: Wed, 25 Sep 2024 10:17:01 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Elizabeth Samuel --- Samples/office-keyboard-shortcuts/README.md | 6 +++--- Samples/office-keyboard-shortcuts/manifest-localhost.xml | 2 +- Samples/office-keyboard-shortcuts/manifest.xml | 2 +- Samples/office-keyboard-shortcuts/src/taskpane.js | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Samples/office-keyboard-shortcuts/README.md b/Samples/office-keyboard-shortcuts/README.md index 0fbbe8e1..d87e5229 100644 --- a/Samples/office-keyboard-shortcuts/README.md +++ b/Samples/office-keyboard-shortcuts/README.md @@ -19,7 +19,7 @@ description: "This sample shows how to add keyboard shortcuts to your Office Add ## Summary -This sample shows how to create custom keyboard shortcuts for an Office Add-in. Keyboard shortcuts let power users quickly use you add-in's features and give accessibility options to avoid a mouse. In this sample, the following shortcuts are configured. +This sample shows how to create custom keyboard shortcuts for an Office Add-in. Keyboard shortcuts let power users quickly use your add-in's features and give accessibility options to avoid using a mouse. In this sample, the following shortcuts are configured. - **Ctrl+Alt+1**: Opens the add-in's task pane. - **Ctrl+Alt+2**: Hides the add-in's task pane. @@ -90,7 +90,7 @@ Run this sample in Excel or Word. The add-in web files are served from this repo If you prefer to host the web server for the sample on your computer, follow these steps. 1. Install a recent version of [npm](https://www.npmjs.com/get-npm) and [Node.js](https://nodejs.org/) on your computer. To verify if you've already installed these tools, run the commands `node -v` and `npm -v` in your terminal. -1. You need http-server to run the local web server. If you haven't installed this yet you can do this with the following command. +1. You need http-server to run the local web server. If you haven't installed this yet, you can do this with the following command. ```console npm install --global http-server @@ -135,7 +135,7 @@ Once the add-in is loaded, try out its functionality. 1. Press **Ctrl+Alt+1** on your keyboard to open the add-in's task pane. > [!NOTE] - > If the keyboard shortcut is already in use in Excel or Word, a dialog will be shown, so that you can select which action you'd like to map to the shortcut. Once you select an action, you can change your preference by invoking the **Reset Office Add-in Shortcut Preferences** command from the search field. + > If the keyboard shortcut is already in use in Excel or Word, a dialog will be shown so that you can select which action you'd like to map to the shortcut. Once you select an action, you can change your preference by invoking the **Reset Office Add-in Shortcut Preferences** command from the search field. > > ![The Reset Office Add-in Shortcut Preferences option in Excel.](./assets/office-keyboard-shortcuts-reset.png) diff --git a/Samples/office-keyboard-shortcuts/manifest-localhost.xml b/Samples/office-keyboard-shortcuts/manifest-localhost.xml index 3fad8b62..79c73f9c 100644 --- a/Samples/office-keyboard-shortcuts/manifest-localhost.xml +++ b/Samples/office-keyboard-shortcuts/manifest-localhost.xml @@ -124,7 +124,7 @@ - + diff --git a/Samples/office-keyboard-shortcuts/manifest.xml b/Samples/office-keyboard-shortcuts/manifest.xml index b7ef35a7..6e2fc329 100644 --- a/Samples/office-keyboard-shortcuts/manifest.xml +++ b/Samples/office-keyboard-shortcuts/manifest.xml @@ -124,7 +124,7 @@ - + diff --git a/Samples/office-keyboard-shortcuts/src/taskpane.js b/Samples/office-keyboard-shortcuts/src/taskpane.js index e645d079..d91e7803 100644 --- a/Samples/office-keyboard-shortcuts/src/taskpane.js +++ b/Samples/office-keyboard-shortcuts/src/taskpane.js @@ -80,5 +80,5 @@ if (host === Office.HostType.Excel) { // Display the shortcut conflict dialog for testing. Office.actions.associate("TestConflict", () => { -console.log("Display the shortcut conflict dialog for testing."); + console.log("Display the shortcut conflict dialog for testing."); });