New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: sample by attribute key, message or any hash #3

Open

samber opened this issue Oct 5, 2023 · 0 comments

Owner

samber commented Oct 5, 2023 •

edited

Loading

Some ideas:

slogsampling.ThresholdSamplingOption{
	Rate: 100,
        ByHash: func(r *slog.Record) []byte {
              return []byte(r.Message)
        },
}

slogsampling.ThresholdSamplingOption{
	Rate: 100,
        ByHash: func(r *slog.Record) []byte {
              return BloomFilter([]byte(r.Message))
        },
}

slogsampling.ThresholdSamplingOption{
	Rate: 100,
        ByAttributeKey: []string{"http", "request", "header", "cf-connecting-ip"},
}

slogsampling.ThresholdSamplingOption{
	Rate: 100,
        BySource: true,   // might be very costly to look for stacktrace
}

slogsampling.ThresholdSamplingOption{
	Rate: 100,
        ByDistance: slogsampling.LevenshteinDistance(xxx),   // just brainstorming - definitely a VERY bad idea 😁
}

We have to keep track of hash/keys. A garbage collector must remove old entries in LRU or LFU manner.

The bloom filter could be embedded into the library on behalf of the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment