{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":44253420,"defaultBranch":"master","name":"edk2","ownerLogin":"samimujawar","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2015-10-14T14:32:13.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11646367?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726710054.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"c8c5caffeeba3f5818b568b68386557b5d2d070a","ref":"refs/heads/3323_add_sami_maintainer_arm_packages_v1","pushedAt":"2024-09-19T01:40:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"Maintainers.txt: Add Sami Mujawar as maintainer for Arm modules\n\nI intend to help with maintenance of the following Arm modules:\n ArmPkg/\n ArmPlatformPkg/\n ArmVirtPkg/\n MdePkg/Include/Library/ArmLib.h\n\nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"Maintainers.txt: Add Sami Mujawar as maintainer for Arm modules"}},{"before":"3cec5e1fc3f0032f7ca083d342e4aa16d3715faf","after":"00fd77a43b9625c4924ec252e72765bf002a1805","ref":"refs/heads/3239_fix_virtio_scsi_issue_v1","pushedAt":"2024-08-02T09:15:29.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Merge branch 'master' into 3239_fix_virtio_scsi_issue_v1","shortMessageHtmlLink":"Merge branch 'master' into 3239_fix_virtio_scsi_issue_v1"}},{"before":"d871f28975bf59c23f704b2996abad590c69b91a","after":"3cec5e1fc3f0032f7ca083d342e4aa16d3715faf","ref":"refs/heads/3239_fix_virtio_scsi_issue_v1","pushedAt":"2024-08-02T07:58:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Pass correct virtio-scsi request size\n\nThe patch at \"1fc55a3933b0 OvmfPkg: Use heap memory\nfor virtio-scsi request\" modified the virtio-scsi\nrequest header memory to be allocated from the heap.\nIn doing so the request structure header which was\na local variable on the stack was converted to be a\npointer. This required adjusting the size computation\nfor the request header to reflect that the structure\nwas changed to a pointer.\nUnfortunately, this was missed out in the call to\nVirtioAppendDesc() for enqueuing the request due to\nwhich only 8 bytes were being shared with the host\ninstead of the size of the VIRTIO_SCSI_REQ structure\nwhich is 51 bytes.\n\nThis resulted in the following error message to\nbe printed by qemu: \"qemu-system-: wrong size\nfor virtio-scsi headers\" and the virtio-scsi\nfunctionality degraded.\n\nTherefore, pass the correct size of the virtio-scsi\nrequest header when enqueuing the request.\n\nReported-by: Aithal Srikanth \nTested-by: Aithal Srikanth \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Pass correct virtio-scsi request size"}},{"before":null,"after":"d871f28975bf59c23f704b2996abad590c69b91a","ref":"refs/heads/3239_fix_virtio_scsi_issue_v1","pushedAt":"2024-08-02T03:40:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Pass correct virtio-scsi request size\n\nThe patch at \"1fc55a3933b0 OvmfPkg: Use heap memory\nfor virtio-scsi request\" modified the virtio-scsi\nrequest header memory to be allocated from the heap.\nIn doing so the request structure header which was\na local variable on the stack was converted to be a\npointer. This required adjusting the size computation\nfor the request header to reflect that the structure\nwas changed to a pointer.\nUnfortunately, this was missed out in the call to\nVirtioAppendDesc() for enqueuing the request due to\nwhich only 8 bytes were being shared with the host\ninstead of the size of the VIRTIO_SCSI_REQ structure\nwhich is 51 bytes.\n\nThis resulted in the following error message to\nbe printed by qemu: \"qemu-system-: wrong size\nfor virtio-scsi headers\" and the virtio-scsi\nfunctionality degraded.\n\nTherefore, pass the correct size of the virtio-scsi\nrequest header when enqueuing the request.\n\nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Pass correct virtio-scsi request size"}},{"before":"cffba5873ab2cc5a84bea586c93a869c24ac3ff9","after":"fb29ceb99a1b0cb22f3511daef020db3c22b4330","ref":"refs/heads/1971_fix_virtio_issues_v1","pushedAt":"2024-07-31T10:53:46.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Merge branch 'master' into 1971_fix_virtio_issues_v1","shortMessageHtmlLink":"Merge branch 'master' into 1971_fix_virtio_issues_v1"}},{"before":"32796b273eb76cc53a78129c947bd96c9861874a","after":"cffba5873ab2cc5a84bea586c93a869c24ac3ff9","ref":"refs/heads/1971_fix_virtio_issues_v1","pushedAt":"2024-07-30T14:55:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Use heap memory for virtio-scsi request\n\nThe storage space for virtio-scsi request header being shared\nwith the host was from the stack as the request structure was\na local function variable.\n\nA bug in the VMM can corrupt the stack space, and such issues\ncan be very hard to debug.\n\nNote: This is only an issue with a normal guest VM (non-CCA).\nA CCA guest VM would perform bounce buffering for sharing the\ndata and therefore not have this issue.\n\nInstead of using the stack for sharing the data with the host,\nmemory can be allocated from the heap pool. However, pool\nallocations are not any safer in terms of pages being shared\nbetween different allocations, and so mapping a pool allocation\nfor DMA may expose it to potential corruption by the VMM in\nexactly the same way. The only difference is the potential\nimpact on program behaviour, which is much higher with the\nstack.\n\nAdditionally, for guest-side corruption heap allocations can\ntake advantage by turning on heap guard to help find the bug.\n\nTherefore, minor improvement can be achieved by allocating\nmemory for the virtio-scsi request header from the heap for\nsharing with the host.\n\nCc: Ard Biesheuvel \nCc: Jiewen Yao \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Use heap memory for virtio-scsi request"}},{"before":"60f483c0bce91251c438155018eaa551a8c6a639","after":"32796b273eb76cc53a78129c947bd96c9861874a","ref":"refs/heads/1971_fix_virtio_issues_v1","pushedAt":"2024-07-24T12:48:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Use heap memory for virtio-scsi request\n\nThe storage space for virtio-scsi request header being shared\nwith the host was from the stack as the request structure was\na local function variable.\n\nA bug in the VMM can corrupt the stack space, and such issues\ncan be very hard to debug.\n\nNote: This is only an issue with a normal guest VM (non-CCA).\nA CCA guest VM would perform bounce buffering for sharing the\ndata and therefore not have this issue.\n\nInstead of using the stack for sharing the data with the host,\nmemory can be allocated from the heap pool. However, pool\nallocations are not any safer in terms of pages being shared\nbetween different allocations, and so mapping a pool allocation\nfor DMA may expose it to potential corruption by the VMM in\nexactly the same way. The only difference is the potential\nimpact on program behaviour, which is much higher with the\nstack.\n\nAdditionally, for guest-side corruption heap allocations can\ntake advantage by turning on heap guard to help find the bug.\n\nTherefore, minor improvement can be achieved by allocating\nmemory for the virtio-scsi request header from the heap for\nsharing with the host.\n\nCc: Ard Biesheuvel \nCc: Jiewen Yao \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Use heap memory for virtio-scsi request"}},{"before":"c1a45a317ca0dae471b30d994c8968d1ef59bbbc","after":"60f483c0bce91251c438155018eaa551a8c6a639","ref":"refs/heads/1971_fix_virtio_issues_v1","pushedAt":"2024-07-01T12:57:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Use heap memory for virtio-scsi request\n\nThe storage space for virtio-scsi request header being shared\nwith the host was from the stack as the request structure was\na local function variable.\n\nThis approach is potentially unsafe as the stack data is being\nshared with the host.\n\nTherefore, allocate memory for the virtio-scsi request header\nfrom the heap for sharing with the host.\n\nCc: Ard Biesheuvel \nCc: Jiewen Yao \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Use heap memory for virtio-scsi request"}},{"before":null,"after":"c1a45a317ca0dae471b30d994c8968d1ef59bbbc","ref":"refs/heads/1971_fix_virtio_issues_v1","pushedAt":"2024-07-01T11:03:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"OvmfPkg: Use heap memory for virtio-scsi request\n\nThe storage space for virtio-scsi request header being shared\nwith the host was from the stack as the request structure was\na local function variable.\n\nThis approach is potentially unsafe as the stack data is being\nshared with the host.\n\nTherefore, allocate memory for the virtio-scsi request header\nfrom the heap for sharing with the host.\n\nCc: Ard Biesheuvel \nCc: Jiewen Yao \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"OvmfPkg: Use heap memory for virtio-scsi request"}},{"before":null,"after":"62dfbfd8ad5b2fb41b180f3e8240931d12ca66bb","ref":"refs/heads/REVIEW_3086_aml_add_integer_package_v2","pushedAt":"2024-05-09T10:42:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg: Adds integer to the AML package node\n\nAdds an AmlAddIntegerToNamedPackage() API to generate AML code,\nwhich adds an integer value to the package node.\n\nCc: Pierre Gondois \nCc: Sami Mujawar \nSigned-off-by: Abdul Lateef Attar \nReviewed-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg: Adds integer to the AML package node"}},{"before":"33da5003b22fea99e93ff4b2e837d89d3e6f0881","after":"065ab87e80eb432b594be1eaa190674354a99984","ref":"refs/heads/2865_arm_cca_v2","pushedAt":"2024-04-12T13:14:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmVirtPkg: ArmCcaIoMmu: Provide an implementation for SetAttribute\n\nThe patch at \"049695a0b1e2 MdeModulePkg/PciBusDxe: Add feedback\nstatus for PciIoMap\" adds support to propagate the error code\nfollowing the invocation of the IoMmu protocol SetAttribute()\noperation.\n\nSince the ArmCcaIoMmuDxe implementation of the SetAttribute()\nfunction returned EFI_UNSUPPORTED, it resulted in the virtio\ndisk not being mounted.\n\nAlthough there is nothing to be done in SetAttribute(), follow\nthe approach as done by the patch at \"97c3f5b8d272 Provide an\nimplementation for SetAttribute\" to validate the IoMmu access\nmethod being requested against the IoMmu mapping operation and\nreturn a suitable return code.\n\nCc: Ard Biesheuvel \nCc: Leif Lindholm \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"ArmVirtPkg: ArmCcaIoMmu: Provide an implementation for SetAttribute"}},{"before":null,"after":"33da5003b22fea99e93ff4b2e837d89d3e6f0881","ref":"refs/heads/2865_arm_cca_v2","pushedAt":"2024-04-12T10:00:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmVirtPkg: ArmCcaIoMmu: Provide an implementation for SetAttribute\n\nThe patch at \"049695a0b1e2 MdeModulePkg/PciBusDxe: Add feedback\nstatus for PciIoMap\" adds support to propagate the error code\nfollowing the invocation of the IoMmu protocol SetAttribute()\noperation.\n\nSince the ArmCcaIoMmuDxe implementation of the SetAttribute()\nfunction returned EFI_UNSUPPORTED, it resulted in the virtio\ndisk not being mounted.\n\nAlthough there is nothing to be done in SetAttribute(), follow\nthe approach as done by the patch at \"97c3f5b8d272 Provide an\nimplementation for SetAttribute\" to validate the IoMmu access\nmethod being requested against the IoMmu mapping operation and\nreturn a suitable return code.\n\nCc: Ard Biesheuvel \nCc: Leif Lindholm \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"ArmVirtPkg: ArmCcaIoMmu: Provide an implementation for SetAttribute"}},{"before":"b5983f657d5d955502d3128de1c16e23171b9129","after":"d48c8514b41fa0f2b47476d6f95fd80cb2b2e023","ref":"refs/heads/REVIEW_3045_ArmPkg_Remove_ArmCortexA5x_ArmCortexA9_files_v1","pushedAt":"2024-04-05T02:44:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmPkg: Remove ArmCortexA9.h\n\nThe last reference to ArmCortexA9.h in the edk2 repository\nwas removed in:\na913ad02479d (\"ArmPlatformPkg: remove ArmVExpressPkg\")\n\nThe last reference to the file in the edk2-platforms\nrepository was agreed to be dropped:\nhttps://edk2.groups.io/g/devel/message/115378\n\nCc: Leif Lindholm \nCc: Ard Biesheuvel \nCc: Sami Mujawar \nSigned-off-by: Pierre Gondois \nReviewed-by: Ard Biesheuvel \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"ArmPkg: Remove ArmCortexA9.h"}},{"before":null,"after":"b5983f657d5d955502d3128de1c16e23171b9129","ref":"refs/heads/REVIEW_3045_ArmPkg_Remove_ArmCortexA5x_ArmCortexA9_files_v1","pushedAt":"2024-04-05T02:39:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmPkg: Remove ArmCortexA9.h\n\nThe last reference to ArmCortexA9.h in the edk2 repository\nwas removed in:\na913ad02479d (\"ArmPlatformPkg: remove ArmVExpressPkg\")\n\nThe last reference to the file in the edk2-platforms\nrepository was agreed to be dropped:\nhttps://edk2.groups.io/g/devel/message/115378\n\nSigned-off-by: Pierre Gondois \nReviewed-by: Ard Biesheuvel \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"ArmPkg: Remove ArmCortexA9.h"}},{"before":null,"after":"af7cc5ba836c5363d2e04226bac1cd4de348a764","ref":"refs/heads/2954_kvmtool_fix_acpi_dt_selection_v1","pushedAt":"2024-03-26T16:26:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmVirtPkg: Kvmtool: Fix ACPI/DT boot selection\n\nThe Kvmtool guest firmware uses the dynamic HII\nPCD PcdForceNoAcpi to determine if ACPI tables\nor the DT must be used for booting an OS.\n\nThis PcdForceNoAcpi is a BOOLEAN value that can\nbe configured using the variable \"ForceNoAcpi\"\nspecifing the gOvmfVariableGuid GUID which is\n\"50BEA1E5-A2C5-46E9-9B3A-59596516B00A\".\n\nHowever, this feature was not working as the\nPCD was not defined in the platform DSC file\nand the DEPEX section in KvmtoolPlatfomDxe.inf\nwas not set correctly.\n\nTherefore, fix this issue so that the ACPI/DT\nboot selection can be done from the UEFI shell\nas shown below.\n\n1. Check the status of the 'ForceNoAcpi' variable\n setvar ForceNoAcpi -guid\n \"50BEA1E5-A2C5-46E9-9B3A-59596516B00A\"\n -nv -bs\n\n Value 00 indicates ACPI boot\n Value 01 indicates DT boot\n\n2. Set the boot mode to ACPI\n setvar ForceNoAcpi -guid\n \"50BEA1E5-A2C5-46E9-9B3A-59596516B00A\"\n -nv -bs =0x00\n\n3. Set the boot mode to DT\n setvar ForceNoAcpi -guid\n \"50BEA1E5-A2C5-46E9-9B3A-59596516B00A\"\n -nv -bs =0x01\n\nCc: Ard Biesheuvel \nCc: Leif Lindholm \nCc: Gerd Hoffmann \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"ArmVirtPkg: Kvmtool: Fix ACPI/DT boot selection"}},{"before":"f221fe88b3443c59133b599ed2b324caec43a594","after":"08917fe9ce255958eeb57baec8db8e7c4828ff1a","ref":"refs/heads/REVIEW_2997_require_pkg_node_hierarchy_v2","pushedAt":"2024-03-13T08:19:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SSDT: Require Package node in hierarchy\n\nThe code was incorrectly assuming that root nodes had to be physical\npackage nodes and vice versa. This is not always true, so update the\ncheck to simply require exactly one package node somewhere in the\nhierarchy.\n\nCc: Pierre Gondois \nCc: Sami Mujawar \nSigned-off-by: Jeshua Smith \nReviewed-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg/SSDT: Require Package node in hierarchy"}},{"before":"c49f1aeefad3b1006af6b0066a85c74af22f028f","after":"f221fe88b3443c59133b599ed2b324caec43a594","ref":"refs/heads/REVIEW_2997_require_pkg_node_hierarchy_v2","pushedAt":"2024-03-12T18:55:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SSDT: Require Package node in hierarchy\n\nThe code was incorrectly assuming that root nodes had to be physical\npackage nodes and vice versa. This is not always true, so update the\ncheck to simply require exactly one package node somewhere in the\nhierarchy.\n\nCc: Pierre Gondois \nCc: Sami Mujawar \nSigned-off-by: Jeshua Smith \nReviewed-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg/SSDT: Require Package node in hierarchy"}},{"before":null,"after":"c49f1aeefad3b1006af6b0066a85c74af22f028f","ref":"refs/heads/REVIEW_2997_require_pkg_node_hierarchy_v2","pushedAt":"2024-03-12T17:15:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SSDT: Require Package node in hierarchy\n\nThe code was incorrectly assuming that root nodes had to be physical\npackage nodes and vice versa. This is not always true, so update the\ncheck to simply require exactly one package node somewhere in the\nhierarchy.\n\nSigned-off-by: Jeshua Smith \nReviewed-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg/SSDT: Require Package node in hierarchy"}},{"before":null,"after":"efb16ce9d446ebf127d360775002c5b920795292","ref":"refs/heads/3007_dynamictables_reorg_arch_namespace_v1","pushedAt":"2024-03-04T16:38:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg: Identify common Arm namespace objects\n\nIdentify the Arm namespace objects that can be moved to\nthe Arch Common namespace. Also, identify the objects\nthat can be dropped.\n\nCc: Pierre Gondois \nCc: Yeo Reum Yun \nCc: Sunil V L \nCc: AbdulLateef Attar \nCc: Jeshua Smith \nCc: Jeff Brasen \nCc: Girish Mahadevan \nCc: Leif Lindholm \nCc: Meenakshi Aggarwal \nSigned-off-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg: Identify common Arm namespace objects"}},{"before":"a34ff64faa676f5b1dec296450d2c6769f0fd3e1","after":"1c8d149efde5fcd48405156d33cb3a268ead07df","ref":"refs/heads/REVIEW_2925_serialportfixup_no_interrupt_v2","pushedAt":"2024-03-04T09:43:54.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Merge branch 'master' into REVIEW_2925_serialportfixup_no_interrupt_v2","shortMessageHtmlLink":"Merge branch 'master' into REVIEW_2925_serialportfixup_no_interrupt_v2"}},{"before":"21d77dc8268af39e6d1d1447fa1ebfc6b48abe73","after":"a34ff64faa676f5b1dec296450d2c6769f0fd3e1","ref":"refs/heads/REVIEW_2925_serialportfixup_no_interrupt_v2","pushedAt":"2024-03-04T09:20:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only\n\nAdd interrupt node to the AML description of the serial-port only if the\nIRQ ID from the Configuration Manager is a valid SPI (shared processor\ninterrupt) or an extended SPI. So, for DBG2 UART ports where interrupt\nis not mandatory, adding of an interrupt node in the AML description\nusing Serial Port Fixup Library can be ignored if the UART is not\ndefined with a valid SPI, like in N1SDP.\n\nThis update generates the interrupt node for the valid SPI range using\nthe AML Codegen API instead of updating it using the AML Fixup API.\n\nCc: Sami Mujawar \nCc: Pierre Gondois \nSigned-off-by: Himanshu Sharma \nReviewed-by: Sami Mujawar \nReviewed-by: Pierre Gondois ","shortMessageHtmlLink":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs …"}},{"before":"3d926a8c3b97c53cc96de4c98316c48af5d02dc6","after":"21d77dc8268af39e6d1d1447fa1ebfc6b48abe73","ref":"refs/heads/REVIEW_2925_serialportfixup_no_interrupt_v2","pushedAt":"2024-03-01T17:27:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only\n\nAdd interrupt node to the AML description of the serial-port only if the\nIRQ ID from the Configuration Manager is a valid SPI (shared processor\ninterrupt) or an extended SPI. So, for DBG2 UART ports where interrupt\nis not mandatory, adding of an interrupt node in the AML description\nusing Serial Port Fixup Library can be ignored if the UART is not\ndefined with a valid SPI, like in N1SDP.\n\nThis update generates the interrupt node for the valid SPI range using\nthe AML Codegen API instead of updating it using the AML Fixup API.\n\nSigned-off-by: Himanshu Sharma \nReviewed-by: Sami Mujawar \nReviewed-by: Pierre Gondois ","shortMessageHtmlLink":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs …"}},{"before":null,"after":"3d926a8c3b97c53cc96de4c98316c48af5d02dc6","ref":"refs/heads/REVIEW_2925_serialportfixup_no_interrupt_v2","pushedAt":"2024-03-01T15:04:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only\n\nAdd interrupt node to the AML description of the serial-port only if the\nIRQ ID from the Configuration Manager is a valid SPI (shared processor\ninterrupt) or an extended SPI. So, for DBG2 UART ports where interrupt\nis not mandatory, adding of an interrupt node in the AML description\nusing Serial Port Fixup Library can be ignored if the UART is not\ndefined with a valid SPI, like in N1SDP.\n\nThis update generates the interrupt node for the valid SPI range using\nthe AML Codegen API instead of updating it using the AML Fixup API.\n\nSigned-off-by: Himanshu Sharma \nReviewed-by: Sami Mujawar \nReviewed-by: Pierre Gondois ","shortMessageHtmlLink":"DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs …"}},{"before":"3aa0fbb20a49dede5d5c19a49a2696622e4c48bb","after":"f5173401f473b39ffa54ffc9c6ea2c742777501a","ref":"refs/heads/REVIEW_2831_stmm_arch_independent_cpu_driver_v3","pushedAt":"2024-02-27T11:40:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver\n\nUpdate entry point library for Arm to use the new architecture independent\nStandaloneMmCpu driver.\n\nSigned-off-by: Tuan Phan \nReviewed-by: levi.yun \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver"}},{"before":"760866e1bd5725f3f20fc98802a77154eb91dfad","after":"7db350fd3bfd113b46b5f774d724f3417147b73c","ref":"refs/heads/REVIEW_2986_basetools_pcd_declare_lib_instance_v1","pushedAt":"2024-01-31T10:12:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"Basetools: Include PCD declarations from Library Instance\n\nThe patch \"[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver\narchitecture independent\" (https://edk2.groups.io/g/devel/message/109178)\nremoved ArmPkg/ArmPkg.dec from the Packages section in the\nINF file: StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf\n\nThis change was done as part of making the StandaloneMmCpu driver\narchitecture independent.\n\nAlthough this change is correct, it results in a side effect\nhere some platforms that utilise PCDs declared in ArmPkg.dec are\nno longer declared.\n\nAn example of this issue can be seen when building\nedk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc\n\n$ build -a AARCH64 -t GCC -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc\nbuild.py...\n/mnt/source/edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf(23):\n error F001: PCD (gArmTokenSpaceGuid.PcdFdBaseAddress) used in\n FDF is not declared in DEC files.\n\nAs seen above, removing ArmPkg.dec from the Packages section in the\nStandAloneMmCpu Driver Inf file triggers build failure.\nAlthough, ArmPkg.dec is included in other Library Instances,\nthe build system does not include the declarations from\n.dec files defined in Library instances.\n\nThe build system only includes the PCD declarations from DEC files\nthat are specified in INF files for Modules (components).\n\nTherefore, extend the build system to include the Packages from\nLibrary Instances so that the PCD declarations from the respective package\nDEC files are included.\n\nThis patch can be seen on\n https://github.com/LeviYeoReum/edk2/tree/levi/2848_dec_check_on_library\n\nSigned-off-by: levi.yun \nTested-by: Pierre Gondois \nReviewed-by: Rebecca Cran \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"Basetools: Include PCD declarations from Library Instance"}},{"before":"8673f322283260e576a8ebb9ae78156bf0877b56","after":"11012bc4efc14bf32dcc101a1f70e02aaa1ed7b3","ref":"refs/heads/REVIEW_2955_generic_watchdog_improvements_v5","pushedAt":"2024-01-30T11:11:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmPkg: Disable watchdog interaction after exiting boot services\n\nUpdate GenericWatchdogDxe to disable watchdog interaction after exiting\nboot services. Also, move the mEfiExitBootServicesEvent event to the top\nof the file with the other static variables.\n\nSigned-off-by: Rebecca Cran \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"ArmPkg: Disable watchdog interaction after exiting boot services"}},{"before":null,"after":"8673f322283260e576a8ebb9ae78156bf0877b56","ref":"refs/heads/REVIEW_2955_generic_watchdog_improvements_v5","pushedAt":"2024-01-30T11:01:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"ArmPkg: Disable watchdog interaction after exiting boot services\n\nUpdate GenericWatchdogDxe to disable watchdog interaction after exiting\nboot services. Also, move the mEfiExitBootServicesEvent event to the top\nof the file with the other static variables.\n\nSigned-off-by: Rebecca Cran \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"ArmPkg: Disable watchdog interaction after exiting boot services"}},{"before":"189f8416b8bd88e9716bab0dba623d7862613402","after":"b9900f0b269efc5eeb712ab15c02e84869e3ff41","ref":"refs/heads/REVIEW_2641_dynamictables_psd_cpc_support_v6","pushedAt":"2024-01-29T15:22:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg: Exempt some _CPC field from checks\n\nWhen generating _CPC objects, some fields are mandatory by spec [1].\nSome fields cannot be supported by a the Juno platform, which is used\nto test the _CPC generation. Therefore, rely on the\nPcdDevelopmentPlatformRelaxations Pcd to either:\n- warn about the missing fields and and let the OS handle the\n missing information\n- consider the missing fields as an error\n\n_CPC fields that are exempted from checks when the Pcd is set:\n- PerformanceLimitedRegister\n- ReferencePerformanceCounterRegister\n- DeliveredPerformanceCounterRegister\n\n[1] Cf. non-optional fields in:\n ACPI 6.5, s8.4.6.1 '_CPC (Continuous Performance Control)'\n\nSigned-off-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg: Exempt some _CPC field from checks"}},{"before":null,"after":"189f8416b8bd88e9716bab0dba623d7862613402","ref":"refs/heads/REVIEW_2641_dynamictables_psd_cpc_support_v6","pushedAt":"2024-01-29T15:18:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"DynamicTablesPkg: Exempt some _CPC field from checks\n\nWhen generating _CPC objects, some fields are mandatory by spec [1].\nSome fields cannot be supported by a the Juno platform, which is used\nto test the _CPC generation. Therefore, rely on the\nPcdDevelopmentPlatformRelaxations Pcd to either:\n- warn about the missing fields and and let the OS handle the\n missing information\n- consider the missing fields as an error\n\n_CPC fields that are exempted from checks when the Pcd is set:\n- PerformanceLimitedRegister\n- ReferencePerformanceCounterRegister\n- DeliveredPerformanceCounterRegister\n\n[1] Cf. non-optional fields in:\n ACPI 6.5, s8.4.6.1 '_CPC (Continuous Performance Control)'\n\nSigned-off-by: Pierre Gondois \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"DynamicTablesPkg: Exempt some _CPC field from checks"}},{"before":null,"after":"3aa0fbb20a49dede5d5c19a49a2696622e4c48bb","ref":"refs/heads/REVIEW_2831_stmm_arch_independent_cpu_driver_v3","pushedAt":"2024-01-26T10:15:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"samimujawar","name":"Sami Mujawar","path":"/samimujawar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11646367?s=80&v=4"},"commit":{"message":"StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver\n\nUpdate entry point library for Arm to use the new architecture independent\nStandaloneMmCpu driver.\n\nSigned-off-by: Tuan Phan \nReviewed-by: levi.yun \nReviewed-by: Sami Mujawar ","shortMessageHtmlLink":"StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOVQwMTo0MDo1NC4wMDAwMDBazwAAAAS6UMhv","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMS0yNlQxMDoxNTowMy4wMDAwMDBazwAAAAPpwfR5"}},"title":"Activity · samimujawar/edk2"}