Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Processor now requires URLs in a specific format #30

Open
francescopioscognamiglio opened this issue Apr 19, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@francescopioscognamiglio

Hi all, I found an interesting issue while using the module.

Configuration

I'm using the latest version of the iiif-processor module: 4.0.4.

Problem

I got an error when creating a new Processor object passing a URL with this pattern: https://<domain>/.*/iiif/2/.*.
It seems that it is no longer possible to use this kind of pattern.
Going deeper, I see that a regex requires that between the domain and the /iiif/2 part there are no extra strings here https://github.com/samvera/node-iiif/blob/v4.0.4/src/processor.js#L19.

@mbklein
Copy link
Member

mbklein commented Apr 22, 2024

Thanks for bringing this issue to my attention. I'll take a look at it and see if I can come up with a solution. It might be as easy as removing the beginning-of-string anchor (^) from the regex.

@mbklein mbklein added the bug Something isn't working label Apr 22, 2024
@mbklein mbklein self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants